superset-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mistercrunch commented on a change in pull request #3518: Full Annotation Framework
Date Thu, 01 Jan 1970 00:00:00 GMT
mistercrunch commented on a change in pull request #3518: Full Annotation Framework
URL: https://github.com/apache/incubator-superset/pull/3518#discussion_r157354484
 
 

 ##########
 File path: superset/assets/javascripts/explore/exploreUtils.js
 ##########
 @@ -1,13 +1,30 @@
 /* eslint camelcase: 0 */
 import URI from 'urijs';
 
+export function getChartKey(explore) {
+  const slice = explore.slice;
+  return slice ? ('slice_' + slice.slice_id) : 'slice';
+}
+
+export function getAnnotationJsonUrl(slice_id, form_data, isNative) {
 
 Review comment:
   Agreed, let's merge this first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message