superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] michellethomas opened a new pull request #7047: Adding a warning message when saving title from explore
Date Sat, 16 Mar 2019 01:10:50 GMT
michellethomas opened a new pull request #7047: Adding a warning message when saving title
from explore
URL: https://github.com/apache/incubator-superset/pull/7047
 
 
   It's not super clear that editing the title overrides the chart. If you are trying to create
a new chart by changing the params of an existing chart and you edit the title before "saving
as" a new chart, you'll save over the existing chart. This adds a warning message when a title
change will save over the existing chart. 
   
   The cancel action reverts the title back to the previously saved title.
   
   Tested by
   Testing save and cancel on an existing chart
   Testing editing the title on a new chart (with no popup)
   Testing editing title on dashboard chart (with no popup)
   
   ![superset_title_change](https://user-images.githubusercontent.com/817955/54468772-81f6cd80-474d-11e9-9db9-6a76a5972769.gif)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message