superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] michellethomas commented on a change in pull request #7028: Feature: Adding warning message for sqllab save query
Date Sat, 16 Mar 2019 01:37:24 GMT
michellethomas commented on a change in pull request #7028: Feature: Adding warning message
for sqllab save query
URL: https://github.com/apache/incubator-superset/pull/7028#discussion_r266184281
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/SaveQuery.jsx
 ##########
 @@ -108,6 +110,18 @@ class SaveQuery extends React.PureComponent {
           </Col>
         </Row>
         <br />
+        {this.props.saveQueryWarning && (
+          <div>
+            <Row>
 
 Review comment:
   I need the outer `<div>` to wrap the `<Row>` and `<br />` children. I
at least would need:
   ```
   <div>
     <div>
       <small>
         {this.props.saveQueryWarning}
       </small>
     </div>
     <br />
   </div>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message