superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-io edited a comment on issue #7028: Feature: Adding warning message for sqllab save query
Date Sat, 16 Mar 2019 01:44:09 GMT
codecov-io edited a comment on issue #7028: Feature: Adding warning message for sqllab save
query
URL: https://github.com/apache/incubator-superset/pull/7028#issuecomment-472644061
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=h1)
Report
   > Merging [#7028](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/f760ba8d4c3d23b416b00cb4b382c96cd6631199?src=pr&el=desc)
will **increase** coverage by `7.98%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7028/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7028      +/-   ##
   ==========================================
   + Coverage   64.46%   72.45%   +7.98%     
   ==========================================
     Files         421       77     -344     
     Lines       20521    10603    -9918     
     Branches     2243        0    -2243     
   ==========================================
   - Hits        13229     7682    -5547     
   + Misses       7165     2921    -4244     
   + Partials      127        0     -127
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==)
| `69.1% <ø> (ø)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
| `93.75% <100%> (+0.03%)` | :arrow_up: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
| `55.86% <0%> (-1.03%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
| `83.15% <0%> (-0.47%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
| `74.68% <0%> (-0.22%)` | :arrow_down: |
   | [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==)
| | |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==)
| | |
   | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz)
| | |
   | [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==)
| | |
   | [superset/assets/src/query/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9pbmRleC50cw==)
| | |
   | ... and [336 more](https://codecov.io/gh/apache/incubator-superset/pull/7028/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=footer).
Last update [f760ba8...8b512c0](https://codecov.io/gh/apache/incubator-superset/pull/7028?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message