synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjiva Weerawarana <sanj...@opensource.lk>
Subject Re: get(String url) issues for getting external resources
Date Wed, 22 Mar 2006 11:21:20 GMT
+1. Soumadeep, if a committer commits some code someone else doesn't
like, then its always possible to change the code. Usually that happens
after discussion however - that is, one doesn't go and revert someone
else's commit willy nilly (obviously).

A good example- Dims 

Sanjiva.

On Wed, 2006-03-22 at 16:42 +0600, Eran Chinthaka wrote:
> Hi all,
> 
> First may I know the reason behind Saminda sending a patch, rather than 
> directly committing the code to the svn head ? Any specific reason ?
> 
> Let me give you a hint on Apache style.
> Committers have earned their committership through meritocracy.  So why 
> does a committer wait for the community to review his code ? The normal 
> and the obvious way is that committers commit code directly and we 
> expect the committer to be disciplined in doing so, and which has been 
> the case in *all* the projects *all* the time in Apache.  He must be 
> self disciplined to send code with comply with the discussion went on 
> the community so far.
> 
> If the community is not happy with what some one has committed, they can 
> revert it.
> 
> Going with the above rules, Saminda please go ahead and commit the code, 
> since you have implemented something Synapse community has agreed. Then 
> community can review it, if required.
> 
> -- Chinthaka
> 
> 
> Soumadeep wrote:
> >
> > Saminda,
> >
> >  
> >
> > Going forward please put all new code in the scratch area!! The 
> > community needs to first see what the code is all about before we do 
> > anything with it.
> >
> > Can you please put your code in the scratch are now, so that everyone 
> > can check it.
> >
> >  
> >
> > Thanks
> >
> > Soumadeep
> >
> >  
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: synapse-dev-help@ws.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: synapse-dev-help@ws.apache.org


Mime
View raw message