synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Asankha C. Perera" <asan...@wso2.com>
Subject Re: Proposal to combine the Inline script mediator with the Script mediator
Date Wed, 14 Mar 2007 17:02:33 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Ant<br>
<br>
Kasun has attached the patch to a JIRA here
<a class="moz-txt-link-freetext" href="https://issues.apache.org/jira/browse/SYNAPSE-67">https://issues.apache.org/jira/browse/SYNAPSE-67</a>
for review<br>
<br>
If you are unable to apply the patch, let me know and I will send you a
tar of the changed classes. I had a lot of problems myself with the
patch being incompatible between Kasuns system and mine (some hunk
errors) - possibly due to some crazy line ending issues - even though
both systems are Ubuntu and uses the same version of SVN.. Here is a
list of the changes - note the deleted files.<br>
<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/AbstractTestCase.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/GroovyScriptMediatorTest.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorFactoryTest.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/convertors/JSOMElementConvertorTest.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorSerializationTest.java<br>
D&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/InlineScriptMediatorTest.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorTest.java<br>
D&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMessageContextTest.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediatorFactory.java<br>
D&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/InlineScriptMediatorSerializer.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediatorSerializer.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/JSOMElementConvertor.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/OMElementConvertor.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/RBOMElementConvertor.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/DefaultOMElementConvertor.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/GROOVYOMElementConvertor.java<br>
D&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/InlineScriptMediator.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediator.java<br>
D&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ThreadLocalMessageContext.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMessageContext.java<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
modules/extensions/src/main/resources/META-INF/services/org.apache.synapse.config.xml.MediatorSerializer<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; modules/extensions/pom.xml<br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; pom.xml<br>
<br>
thanks<br>
asankha<br>
<br>
<br>
Asankha C. Perera wrote:
<blockquote cite="mid45F6EC96.6070801@wso2.com" type="cite">
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
Hi Ant<br>
  <br>
Yes this will go into 1.0 RC1 and is complete, and I was just helping
out Kasun with a code review today. This would be attached to the JIRA
tomorrow and you could verify and commit after review.<br>
  <br>
thanks<br>
asankha<br>
  <br>
ant elder wrote:
  <blockquote
 cite="mid71e1b5740703130538j585e630ax65ac254647fd5669@mail.gmail.com"
 type="cite">How are you getting on with this, are you still planing on
looking at it? Is there anything I could do to help? Or take it one if
you don't have time to do it now? Be good to try to get it done in time
for the 1.0 release. <br>
    <br>
&nbsp;&nbsp; ...ant<br>
    <br>
    <div><span class="gmail_quote">On 2/22/07, <b
 class="gmail_sendername">Kasun Samarasinghe</b> &lt;<a
 href="mailto:kasun@wso2.com">kasun@wso2.com</a>&gt; wrote:</span>
    <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left:
1ex;">Hi<br>
      <br>
Currently Synapse supports two variants for script mediation, where the<br>
script could be specified through a property or inline.<br>
      <br>
E.g.<br>
&lt;set-property name="prop" src="scriptfile.LL"/&gt; <br>
      <br>
in mediation<br>
&lt;script key="prop" function="mediation_function"/&gt;<br>
      <br>
      <br>
In line mediators where we specify the script type in it self as LL<br>
E.g.<br>
&lt;script.LL&gt;&lt;![CDATA[<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;some
script......<br>
]]&gt;&lt;/script.LL&gt;<br>
      <br>
I think these could be combined into one single script mediator.&nbsp;&nbsp;Also,<br>
I think its better to explicitly specify the script language, as<br>
guessing the language when the script is specified by a property may <br>
not<br>
always be reliable. So the suggestion is<br>
      <br>
E.g<br>
&lt;script type="LL" [key="prop"] [function="mediation_function"]&gt;<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;![CDATA[..
inline script ..]]&gt;?<br>
&lt;/script&gt; <br>
      <br>
What do you think? I would be happy to raise a jira and submit a patch<br>
for this enhancement<br>
      <br>
thanks<br>
kasun<br>
      <br>
      <br>
      <br>
      <br>
      <br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a
 href="mailto:synapse-dev-unsubscribe@ws.apache.org">synapse-dev-unsubscribe@ws.apache.org</a><br>
For additional commands, e-mail: <a
 href="mailto:synapse-dev-help@ws.apache.org">synapse-dev-help@ws.apache.org
      </a><br>
      <br>
    </blockquote>
    </div>
    <br>
  </blockquote>
---------------------------------------------------------------------
To unsubscribe, e-mail: <a class="moz-txt-link-abbreviated" href="mailto:synapse-dev-unsubscribe@ws.apache.org">synapse-dev-unsubscribe@ws.apache.org</a>
For additional commands, e-mail: <a class="moz-txt-link-abbreviated" href="mailto:synapse-dev-help@ws.apache.org">synapse-dev-help@ws.apache.org</a>
</blockquote>
</body>
</html>

---------------------------------------------------------------------
To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: synapse-dev-help@ws.apache.org


Mime
View raw message