synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From indika kumara <indika.k...@gmail.com>
Subject Re: svn commit: r749210 [1/2] - in /synapse/trunk/java/modules: core/src/main/java/org/apache/synapse/ core/src/main/java/org/apache/synapse/config/ core/src/main/java/org/apache/synapse/config/xml/ core/src/main/java/org/apache/synapse/config/xml/en
Date Mon, 09 Mar 2009 04:38:38 GMT
Thanks .... From next time ... I will commit as possible as small and
related changes

On Sun, Mar 8, 2009 at 2:52 AM, Andreas Veithen
<andreas.veithen@gmail.com> wrote:
> +1
>
> It is indeed preferable to have larger number of commits (each one
> related to one independent change or fix) than to have commits
> touching a large number of files. I think it is also important to
> separate functional changes from non functional changes (e.g. code
> reformatting or applying Java 5 syntax). This is the only way we can
> make sure that there is an appropriate level of review.
>
> Andreas
>
> On Thu, Mar 5, 2009 at 03:59, Ruwan Linton <ruwan.linton@gmail.com> wrote:
>> Indika, please try to not to commit in bulk rather make these commits
>> modular (one concern per commit).
>>
>> It seems this particular commit has introduced a lot of regressions.
>>
>> Thanks,
>> Ruwan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message