synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hubert (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SYNAPSE-534) Make logging of HTTP 500 responses configurable
Date Mon, 04 May 2009 22:34:30 GMT

    [ https://issues.apache.org/jira/browse/SYNAPSE-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705798#action_12705798
] 

Eric Hubert commented on SYNAPSE-534:
-------------------------------------

Do I need to update this patch? I have seen a minor change to the client handler Asankha did
in response to the patch provided by Jaroslav in SYNAPSE-540 or are you fine with this one
and update it on your own (if needed)?

> Make logging of HTTP 500 responses configurable
> -----------------------------------------------
>
>                 Key: SYNAPSE-534
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-534
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>            Reporter: Eric Hubert
>            Priority: Minor
>         Attachments: warnOnHttp500.patch
>
>
> Currently Synapse outputs a warning for any HTTP 500 response, irrespective of the content-type.
Consequently, this also applies to any SOAP fault. I would propose to generaly only log such
server/service responses as a warning. Additionally I would like to make this configurable
via a transport sender parameter. This parameter could be called warnOnHTTP500 and contain
a delimiter separated list of content-types for which a warning shall be logged.
> I started implementing this, ao attached you will find a patch containing changes to
HttpCoreNIOSender, ClientHandler, axis2.xml plus a short addition to the Maven sites transport
documentation.
> The implementation was straight forward and simple but I was uncertain about how to pass
the parameter from HttpCoreNIOSender to ClientHandler. I'm not sure whether my solution to
use the Axis2 ConfigurationContext's properties is acceptable. So I would apreciate feedback/corrections
here.
> If the parameter is missing, there will be no change in functionality. In order to "document"
the change also in the default configuration I changed the axis2.xml to contain the following
line:
> <parameter name="warnOnHTTP500" locked="false">*</parameter>
> which has the same meaning as the missing parameter.
> An example of another valid configuration could look like this:
> <parameter name="warnOnHTTP500" locked="false">x-application/hessian|none</parameter>
> With this configuration a warning would only be logged for 500 responses of content-type
'x-application/hessian' or messages missing a content-type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message