synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruwan Linton <ruwan.lin...@gmail.com>
Subject Re: [jira] Commented: (SYNAPSE-537) Possibility to put server in maintenance mode and reload synapse configuration via JMX
Date Fri, 01 May 2009 22:34:56 GMT
+1 for the propose refactoring... I think it is better to move the
Axis2SynapseController to the package 'synapse.server.axis2'.

Would you like to do this as well?

Thanks,
Ruwan

On Sat, May 2, 2009 at 3:48 AM, Hubert, Eric <Eric.Hubert@foxmobile.com>wrote:

> > With few other changes I have committed the patch. I must say this is a
> > great improvement and this also fixes the shutdown issue.
>
> Great to hear that. Ruwan, thanks for reviewing and applying this patch!
>
> What do you and others think about my suggestion of moving all the server
> related classes from the top level to a new sub package server.
>
> Here is my original comment from the JIRA:
> > > While working on this patch I thought about moving some of the classes
> > in the synapse top level package to a new server subpackage. I actually
> > did not perform this change to ease the review, but I still think it
> would
> > be a good idea.
> > > So what about moving the following classes:
> > > Axis2SynapseController
> > > JmxAdapter
> > > ServerConfigurationInformation
> > > ServerConfigurationInformationFactory
> > > ServerContextInformation
> > > ServerManager
> > > ServerState
> > > ServerStateDetectionStrategy
> > > SynapseController
> > > SynapseControllerFactory
> > > SynapseServer
> > > to
> > > synapse.server
> > > and
> > > ServerManagerView
> > > ServerManagerViewMBean
> > > to
> > > synapse.server.mbean (maybe also renaming them to ServerManagerControl
> > and ServerManagerControlMBean.
>
>


-- 
Ruwan Linton
Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://ruwansblog.blogspot.com

Mime
View raw message