Asankha, thanks for taking a high-level look on
the patch. I would also feel much more comfortable if Ruwan could take an
additional low-level look at the patch. ;-)
I spent a couple of hours doing those changes
spread of several days in which also other changes had been applied to the same
classes, so I needed to update my working copy several times to catch up. I
hope no change slipped through.
I also did some method renaming and removed
unnecessary indirections to make the code more readable. There is still room
for improvements, but I wanted to get out the first chunk to not have to update
too frequently due to parallel changes.
From: Asankha Perera [mailto:email@example.com]
On Behalf Of Asankha C. Perera
Sent: Monday, April 27, 2009 3:17
Subject: Re: [jira] Updated:
(SYNAPSE-536) Error while stoping the Synapse server
I submitted my patch in a new JIRA (https://issues.apache.org/jira/browse/SYNAPSE-537) as could not
locate the existing issue. Maybe Asankha can help out.
I hope someone finds time to review.
Afterwards I will go through all the known issues
on my list regarding the shutdown handling. Ruwan, if you can provide more
details or stack trace I will be happily jump in and help once I find the time
- next weekend at the latest.
I've done a brief look at the changes, and
they seem ok to me at a high level. I think Ruwan should ok this as well with
the recent changes he has been doing on the stop/restart logic.
Asankha C. Perera