synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiranya Jayathilaka (JIRA)" <>
Subject [jira] [Commented] (SYNAPSE-935) PassThrough Transport bug fixes-1
Date Sun, 14 Jul 2013 04:04:50 GMT


Hiranya Jayathilaka commented on SYNAPSE-935:

Hi Rajika,

We should certainly flip the string comparison so that it's resistant to NPE's. This should
be the practice followed throughout. Thanks for pointing that out.

AFAIK the pass through transport has no dependency on the base transport as of now (not surprising
- the old nhttp transport didn't use the base transport either). So lets stick to the existing
implementation at least for the moment.

> PassThrough Transport bug fixes-1
> ---------------------------------
>                 Key: SYNAPSE-935
>                 URL:
>             Project: Synapse
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1
>            Reporter: Dushan Sachinda Abeyruwan
>            Assignee: Hiranya Jayathilaka
>            Priority: Blocker
>              Labels: core
>             Fix For: FUTURE
>         Attachments: passthrough_fix_patch_1_new.txt
> Hi
>   Please find the patch file which contains fixes for following scenario.
> 1. Property mediator to be content aware based the given scope definition.
> 2. Fixed bugs when working with binary messages in RelayUtils.
> 3. BufferFacory re-factored (adding buffer cleanup operation), found the shared buffer
not cleanup properly due to high load tests thus,it causes run time exceptions.
> 4.  Fix for CHUNKING_DISABLE for lager messages (tested messages such as 100k)
>   Did run integration test after applying the patch attached herewith and seems all integration
test have passed successfully.
>       Meantime there are some fixes I have done for content switching issues and some
fixes for RESTful services invocation, will provide those patches in different jira.
> Thanks
> Dushan

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message