synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Veithen <andreas.veit...@gmail.com>
Subject Re: svn commit: r1504950 - /synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java
Date Sat, 03 Aug 2013 18:01:30 GMT
I don't think that this is the correct fix for SYNAPSE-866. My
interpretation is that the original intent of the code you removed was
to avoid logging an exception when the client closes the connection
(which is not a very exceptional situation). The problem is that this
code is triggered also in other situations.

Andreas

On Fri, Jul 19, 2013 at 8:01 PM,  <hiranya@apache.org> wrote:
> Author: hiranya
> Date: Fri Jul 19 18:01:47 2013
> New Revision: 1504950
>
> URL: http://svn.apache.org/r1504950
> Log:
> Fixing SYNAPSE-866; Logging a more general error message with the full stack trace in
case of IllegalStateExceptions
>
> Modified:
>     synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java
>
> Modified: synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java
> URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java?rev=1504950&r1=1504949&r2=1504950&view=diff
> ==============================================================================
> --- synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java
(original)
> +++ synapse/trunk/java/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreNIOSender.java
Fri Jul 19 18:01:47 2013
> @@ -554,11 +554,6 @@ public class HttpCoreNIOSender extends A
>                  lstMetrics.incrementFaultsSending();
>              }
>              log.warn("Connection closed by client : " + worker.getRemoteAddress());
> -        } catch (IllegalStateException e) {
> -            if (lstMetrics != null) {
> -                lstMetrics.incrementFaultsSending();
> -            }
> -            log.warn("Connection closed by client : " + worker.getRemoteAddress());
>          } catch (IOException e) {
>              if (lstMetrics != null) {
>                  lstMetrics.incrementFaultsSending();
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message