synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiranya Jayathilaka (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SYNAPSE-726) AbstractContext.setName() method needs refactoring, coz MBean registrations also happens there.
Date Sun, 21 Sep 2014 22:40:34 GMT

     [ https://issues.apache.org/jira/browse/SYNAPSE-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hiranya Jayathilaka resolved SYNAPSE-726.
-----------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 2.1)
                   3.0

I believe this is fixed now. MBean registration happens conditionally now.

> AbstractContext.setName() method needs refactoring, coz MBean registrations also happens
there.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-726
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-726
>             Project: Synapse
>          Issue Type: Bug
>    Affects Versions: NIGHTLY
>            Reporter: Sameera Jayasoma
>            Assignee: Hiranya Jayathilaka
>             Fix For: 3.0
>
>
> public abstract class AbstractEndpoint{
> ......
>  public void setName(String endpointName) {
>         this.endpointName = endpointName;
>         metricsMBean = new EndpointView(endpointName, this);
>         MBeanRegistrar.getInstance().registerMBean(metricsMBean, "Endpoint", endpointName);
>     }
> ............
> }
> IMHO, we need move this MBean registration code out of this method. setName() should
only set the name. Now it is doing some unrelated actions. Due to bit of code, we faced a
memory leak recently. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message