synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [synapse] vanjikumaran commented on a change in pull request #43: Add documentation for retry.interval feature
Date Sun, 10 May 2020 17:51:44 GMT

vanjikumaran commented on a change in pull request #43:
URL: https://github.com/apache/synapse/pull/43#discussion_r422676323



##########
File path: modules/documentation/src/site/xdoc/userguide/samples/sample705.xml
##########
@@ -58,6 +58,7 @@
       &lt;parameter name="max.deliver.attempts"&gt;3&lt;/parameter&gt;
       &lt;parameter name="max.deliver.drop"&gt;true&lt;/parameter&gt;
       &lt;parameter name="retry.http.status.codes"&gt;500, 504&lt;/parameter&gt;
+      &lt;parameter name="retry.interval"&gt;5000&lt;/parameter&gt;

Review comment:
       It would be good if you can adopt the default value that is in the code [1] 
   
   [1]https://github.com/apache/synapse/pull/41/files#diff-af12a51dc14c81dc0feaf0cfa7e8667aR88




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message