From dev-return-146-apmail-systemml-dev-archive=systemml.apache.org@systemml.incubator.apache.org Mon Dec 21 06:23:27 2015 Return-Path: X-Original-To: apmail-systemml-dev-archive@minotaur.apache.org Delivered-To: apmail-systemml-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93B4718E21 for ; Mon, 21 Dec 2015 06:23:27 +0000 (UTC) Received: (qmail 8859 invoked by uid 500); 21 Dec 2015 06:23:27 -0000 Delivered-To: apmail-systemml-dev-archive@systemml.apache.org Received: (qmail 8818 invoked by uid 500); 21 Dec 2015 06:23:27 -0000 Mailing-List: contact dev-help@systemml.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@systemml.incubator.apache.org Delivered-To: mailing list dev@systemml.incubator.apache.org Received: (qmail 8806 invoked by uid 99); 21 Dec 2015 06:23:27 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2015 06:23:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B925B1A00B2 for ; Mon, 21 Dec 2015 06:23:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.149 X-Spam-Level: **** X-Spam-Status: No, score=4.149 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_REPLY=1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id C7YvPOpopLPN for ; Mon, 21 Dec 2015 06:23:21 +0000 (UTC) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 3072C428FF for ; Mon, 21 Dec 2015 06:23:21 +0000 (UTC) Received: by mail-io0-f181.google.com with SMTP id 186so147009215iow.0 for ; Sun, 20 Dec 2015 22:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=4bucY0T5Rc943Kv6ENwSikA97/lB1f5L0+iuJ6wFifk=; b=pDixU0ELHeMC5o3x7keSqdWBM3kHvooQRZAEH0bPP60AhbnTDfGzih0fJNUmDzHNhf ACpXw+zGZ33maml+b10y1RakffPnfN4sWd1REcnEFncqPLC7+6Yfsi/VmIYCut7yLBkg s12Tupm8kI+XjYSSWD6Bz3EEeIOg/QzFnReeFBLzDlYHYcBKn4iI+RtczTBbV4oBsBvR +KdVQRuYQhMGSL45PWocAoEmVyyNAMjs19+bnVJsqS46dkRuhq4F3MooA4xqpodSvOtC ZnlQ0PG+nJlcUaYO8e++z5ZnlJi918K2csQR4gtVDpUFBiosDLl7Rnb5KlQ6AELA/goe xE3g== MIME-Version: 1.0 X-Received: by 10.107.132.162 with SMTP id o34mr9879094ioi.13.1450679000812; Sun, 20 Dec 2015 22:23:20 -0800 (PST) Received: by 10.64.145.164 with HTTP; Sun, 20 Dec 2015 22:23:20 -0800 (PST) In-Reply-To: References: Date: Sun, 20 Dec 2015 22:23:20 -0800 Message-ID: Subject: Re: Closing pull requests From: Luciano Resende To: "dev@systemml.incubator.apache.org" Content-Type: multipart/alternative; boundary=001a113f33e886d34a052762868d --001a113f33e886d34a052762868d Content-Type: text/plain; charset=UTF-8 On Sunday, December 20, 2015, Reynold Xin wrote: > Unfortunately only the PR submitter or the ASF infra team can close them. > > You can also push a commit to master and close it by using the "close #xxx" > message. > > +1, i guess there isn't much more we can do. > > On Sun, Dec 13, 2015 at 1:04 PM, Deron Eriksson > > wrote: > > > Hi Luciano and others, > > > > I just merged my first pull request from another user into SystemML. > > Previously, before pushing to Apache master I've been doing a "commit > > --amend" to add a "Closes #[PR-NUM]." to the end of the commit message so > > as to let asfgit close the pull request. However, because of the sync > > issues from Apache to GitHub (2 of my last 5 commits seemed to hang the > > propagation), I decided to hold off on the "commit --amend" to try to > keep > > things as simple as possible to avoid any kind of sync issue. > > > > So, the PR merged cleanly and the update shows up on the SystemML project > > on GitHub as expected. However, the PR is not closed because asfgit > didn't > > close it and I don't have permissions to close it. > > > > So, at this stage, does the user close the pull request, or is it > possible > > for me to have permissions to close the pull request? > > > > Thank you, > > Deron > > > -- Sent from my Mobile device --001a113f33e886d34a052762868d--