systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niketan Pansare" <npan...@us.ibm.com>
Subject Re: Remove any of these classes?
Date Mon, 04 Apr 2016 20:49:46 GMT

Hi Deron,

Thanks for catching the unreferenced classes. Here are the classes that I
would recommend removing:
org.apache.sysml.runtime.instructions.spark.functions.ConvertColumnRDDToBinaryBlock
org.apache.sysml.runtime.instructions.spark.functions.ConvertTextLineToBinaryCellFunction
org.apache.sysml.runtime.instructions.spark.functions.ConvertTextToString
org.apache.sysml.runtime.instructions.spark.functions.FindMatrixBlockFromMatrixIndexes
org.apache.sysml.runtime.instructions.spark.functions.LastCellInMatrixBlock

Following classes will be used in the MLPipeline wrappers or for demos, so
I would recommend keeping them:
org.apache.sysml.runtime.instructions.spark.functions.ConvertMLLibBlocksToBinaryBlocks
org.apache.sysml.runtime.instructions.spark.functions.GetMLLibBlocks

The following enums can be removed as they have been moved to
BuiltinFunctionOp and have not been cleaned up:
org.apache.sysml.parser.Expression.AggOp
org.apache.sysml.parser.Expression.ExtBuiltinFunctionOp
org.apache.sysml.parser.Expression.ReorgOp

Thanks,

Niketan Pansare
IBM Almaden Research Center
E-mail: npansar At us.ibm.com
http://researcher.watson.ibm.com/researcher/view.php?person=us-npansar



From:	Deron Eriksson <deroneriksson@gmail.com>
To:	dev@systemml.incubator.apache.org
Date:	04/04/2016 01:18 PM
Subject:	Remove any of these classes?



Hi,

If I search for classes/enums that aren't referenced by other classes in
SystemML, I get the following partial list:

org.apache.sysml.hops.Hop.ExtBuiltInOp
org.apache.sysml.parser.Expression.AggOp
org.apache.sysml.parser.Expression.ExtBuiltinFunctionOp
org.apache.sysml.parser.Expression.ReorgOp
org.apache.sysml.runtime.controlprogram.parfor.opt.MemoTable
org.apache.sysml.runtime.functionobjects.MaxIndex
org.apache.sysml.runtime.functionobjects.MinIndex
org.apache.sysml.runtime.instructions.cp.FileObject
org.apache.sysml.runtime.instructions.spark.data.CountLinesInfo
org.apache.sysml.runtime.instructions.spark.functions.ConvertColumnRDDToBinaryBlock

org.apache.sysml.runtime.instructions.spark.functions.ConvertMLLibBlocksToBinaryBlocks

org.apache.sysml.runtime.instructions.spark.functions.ConvertTextLineToBinaryCellFunction

org.apache.sysml.runtime.instructions.spark.functions.ConvertTextToString
org.apache.sysml.runtime.instructions.spark.functions.FindMatrixBlockFromMatrixIndexes

org.apache.sysml.runtime.instructions.spark.functions.GetMLLibBlocks
org.apache.sysml.runtime.instructions.spark.functions.LastCellInMatrixBlock
org.apache.sysml.runtime.instructions.spark.functions.MatrixVectorBinaryOpFunction

org.apache.sysml.runtime.io.FrameReaderFactory
org.apache.sysml.runtime.io.FrameWriterFactory
org.apache.sysml.runtime.io.WriterMatrixMarketParallel
org.apache.sysml.runtime.matrix.data.PoissonRandomMatrixGenerator
org.apache.sysml.runtime.matrix.data.TaggedInt
org.apache.sysml.runtime.matrix.data.TaggedPartialBlock
org.apache.sysml.runtime.matrix.data.WeightedPairToSortInputConverter
org.apache.sysml.runtime.matrix.data.RuntimeDataFormat
org.apache.sysml.runtime.matrix.mapred.CachedMap
org.apache.sysml.runtime.matrix.mapred.MMCJMRCombiner
org.apache.sysml.runtime.matrix.mapred.MMCJMRReducer
org.apache.sysml.runtime.matrix.sort.CompactDoubleIntInputFormat
org.apache.sysml.runtime.util.BinaryBlockInputFormat
org.apache.sysml.runtime.util.RandN
org.apache.sysml.utils.AppException
org.apache.sysml.utils.Timer
org.apache.sysml.yarn.ropt.ResourceOptimizerCPMigration

Can any of these be deleted?

Deron



Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message