systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dusenberr...@gmail.com
Subject Re: remove castAsScalar?
Date Fri, 22 Apr 2016 18:35:39 GMT
Yeah those both sound great.  Even if we have to possibly support old DML code outside the
project, we can certainly aim to keep our DML code as modern and clean as possible. 

--

Mike Dusenberry
GitHub: github.com/dusenberrymw
LinkedIn: linkedin.com/in/mikedusenberry

Sent from my iPhone.


> On Apr 22, 2016, at 11:29 AM, Deron Eriksson <deroneriksson@gmail.com> wrote:
> 
> In that case, perhaps I could create JIRAs to:
> 1) replace all castAsScalar's in the project with as.scalar's
> 2) if castAsScalar is used in a DML file, issue a log warning such as
> 'castAsScalar has been deprecated, please replace with as.scalar'
> 3) update docs to say castAsScalar has been deprecated.
> 
> That way, we maintain backwards compatibility with older DML outside the
> project while replacing the castAsScalar's in the project.
> 
> Deron
> 
> 
> 
>> On Thu, Apr 21, 2016 at 5:42 PM, Matthias Boehm <mboehm@us.ibm.com> wrote:
>> 
>> Let's be careful not to unnecessarily break backwards compatibility. How
>> about we collect all instances of language builtin functions that we want
>> to remove and clean them up with our 1.0 release later this year? There are
>> other instances like ppred that do not exist in R and meanwhile redundant
>> in DML (but still heavily used).
>> 
>> Regards,
>> Matthias
>> 
>> [image: Inactive hide details for Deron Eriksson ---04/21/2016 05:33:56
>> PM---Hi, In the ongoing discussion concerning printing a matrix]Deron
>> Eriksson ---04/21/2016 05:33:56 PM---Hi, In the ongoing discussion
>> concerning printing a matrix (at
>> 
>> From: Deron Eriksson <deroneriksson@gmail.com>
>> To: dev@systemml.incubator.apache.org
>> Date: 04/21/2016 05:33 PM
>> Subject: remove castAsScalar?
>> ------------------------------
>> 
>> 
>> 
>> Hi,
>> 
>> In the ongoing discussion concerning printing a matrix (at
>> https://github.com/apache/incubator-systemml/pull/120), I noticed that
>> castAsScalar was introduced to the language as a mistake. It has been
>> replaced by as.scalar but castAsScalar has been kept around until now for
>> historical reasons. Since it is redundant and we are an open source
>> project, can we now go ahead and remove it, since having two ways to
>> accomplish the same thing (as.scalar and castAsScalar) can be confusing to
>> new users?
>> 
>> Deron
>> 
>> 
>> 

Mime
  • Unnamed multipart/alternative (inline, 7-Bit, 0 bytes)
View raw message