systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices
Date Mon, 30 Mar 2020 09:59:12 GMT
Baunsgaard commented on issue #871: [SYSTEMDS-314] Python Federated Matrices
URL: https://github.com/apache/systemml/pull/871#issuecomment-605904266
 
 
   > LGTM except for the failing tests. In your comment, you mention that the failing tests
are left in as a reminder to fix some bugs. Why not create a separate PR marked WIP or an
issue in the tracker for that?
   
   it makes sense to have tests fail showing the bugs, especially because it is functionality
that we 'claim' to support in master.
   
   i also think that @kev-inn would be suited for the fixing the bug. Therefore there i see
two ways of going forward, either wait for that fix while being a pull request, or allow the
pull request in that shows a bug in the system now. (i vote for the later (not that i have
a vote) :smile: ).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message