systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
Date Tue, 31 Mar 2020 12:18:22 GMT
kev-inn commented on a change in pull request #873: Update python package, making use of java
distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400865792
 
 

 ##########
 File path: src/main/python/BUILD_INSTRUCTIONS.md
 ##########
 @@ -23,27 +23,34 @@ limitations under the License.
 
 The following steps have to be done for both cases
 
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being
`SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory
being `SYSTEMDS_ROOT` (Root directory of SystemDS)
 - `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
 
-### Building package
+### Building package for release
 
 If we want to build the package for uploading to the repository via `python3 -m twine upload
--repository-url [URL] dist/*` (will be automated in the future)
 
+- Install twine with `pip install --upgrade twine`
 - Run `create_python_dist.py`
 
 ```bash
 python3 create_python_dist.py
 ```
 
 - now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz`
and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current
version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+    1. Create an API-Token in the account (leave the page open or copy the token, it will
only be shown once)
+    2. Execute the command `python3 -m twine upload dist/*`
+        - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend
was available.`
+    3. Username is `__token__`
+    4. Password is the created API-Token **with** `pypi-` prefix
 
 Review comment:
   I can do this for the `Building for development` but the other case is actually for releasing
the package. We probably anyway want to move this somewhere else (and automate it at some
point), but for now should I just rename the file `PUBLISH_INSTRUCTIONS.md`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message