systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] mboehm7 commented on pull request #905: [SYSTEMDS-335] Weighted eviction policy
Date Sun, 03 May 2020 15:00:11 GMT

mboehm7 commented on pull request #905:
URL: https://github.com/apache/systemml/pull/905#issuecomment-623123071


   LGTM. Thanks for the patch @phaniarnab - I think this is a great direction. During the
merge, I fixed the conflicts and simplified `LineageCacheEviction.isSparse` to get the sparsity
flag from the actual object not an estimate over the objects metadata. Down the road, it would
be good to further generalize the different eviction policies to better separate the different
code paths (otherwise, it would get complex and convoluted very quickly) - I left a TODO in
`makeSpace`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message