systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] mboehm7 commented on pull request #881: spark wip for review
Date Sun, 03 May 2020 16:29:46 GMT

mboehm7 commented on pull request #881:
URL: https://github.com/apache/systemml/pull/881#issuecomment-623136782


   LGTM - thanks @gilgenbergg for the patch. Overall, this is a great start. During the merge,
I fixes the licenses (wrong/missing) and did some minor cleanups. There some issues though.
Please, (1) revisit the broadcast handling (don't read broadcasts at the driver), (2) make
the checking of masks and approving of union slices separate functions with hash lookups and
early-abort instead of full nested loop joins, and (3) ensure that common code paths don't
go though (misuse) exception handling. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message