systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] lukas-jkl commented on pull request #904: onnx-systemds implementation
Date Thu, 14 May 2020 17:34:51 GMT

lukas-jkl commented on pull request #904:
URL: https://github.com/apache/systemml/pull/904#issuecomment-628782797


   > > Thank you for the quick review @Baunsgaard ! I've implemented your suggested
changes and have rewritten the documentation in rst files. I am however still a bit unsure
about the yml files. I guess it would not be sufficient to simply add onnx and Jinja to the
pip dependencies as protobuf would also need to be installed?
   > 
   > Since our python tests are executed on Ubuntu-latest it should **hopefully** be as
simple as adding a step,
   > 
   > ```yaml
   > - name: install protobuf
   >    run: {INSERT INSTALL COMMAND HERE }
   > ```
   
   Seems to work now!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message