systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] deutschmn commented on a change in pull request #916: Add to_one_hot builtin function
Date Wed, 20 May 2020 09:43:27 GMT

deutschmn commented on a change in pull request #916:
URL: https://github.com/apache/systemml/pull/916#discussion_r427878926



##########
File path: src/main/java/org/apache/sysds/common/Builtins.java
##########
@@ -173,6 +173,7 @@
 	TAN("tan", false),
 	TANH("tanh", false),
 	TRACE("trace", false),
+	TO_ONE_HOT("to_one_hot", true),

Review comment:
       I have got no particular opinion on this, but I found a function called `one_hot` in
an R package: https://www.rdocumentation.org/packages/mltools/versions/0.3.5/topics/one_hot

   
   Just let me know your final decision and I will change it accordingly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message