systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] mboehm7 commented on pull request #900: [SYSTEMDS-310] Python API Refactor
Date Wed, 27 May 2020 03:30:57 GMT

mboehm7 commented on pull request #900:
URL: https://github.com/apache/systemml/pull/900#issuecomment-634251033


   LGTM - that's a very nice patch @Baunsgaard. 
   
   Just some minor comments: (1) as I've seen it before: the correct spelling is built-in
functions/algorithms (not build-in), (2) usually we try to delete commented code (e.g., `runFedTest.sh`)
and avoid references to transient links as they might change (people will be able to find
the quickstart guide of py4j). I fixed (1) but left (2) for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message