tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAJO-22) The package prefix should be org.apache.tajo.
Date Tue, 02 Jul 2013 02:26:20 GMT

    [ https://issues.apache.org/jira/browse/TAJO-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697423#comment-13697423
] 

Hyunsik Choi edited comment on TAJO-22 at 7/2/13 2:25 AM:
----------------------------------------------------------

Thank you for your contribution. The patch looks great. I've improved your patch as follows:

 * Recover the property key names of *-default.xml files because the key names are not based
on package names.
 ** From this change, I modified TajoConf that contains most of all property keys.
 * Recover pom.xml files for each package because the git address should be kept.
 * Recover the jvm option 'tajo.test' in TaskLauncherImpl because this is not a package name.

I've uploaded the improved patch. I verified 'mvn clean install'. If there is no objection
until tomorrow, I'll commit this patch.
                
      was (Author: hyunsik):
    Thank you for your contribution. The patch looks great. I've improved your patch as follows:

 * Recover the property key names of *-default.xml files because the key names are not based
on package names.
  * From this change, I modified TajoConf that contains most of all property keys.
 * Recover pom.xml files for each package because the git address should be kept.
 * Recover the jvm option 'tajo.test' in TaskLauncherImpl because this is not a package name.

I've uploaded the improved patch. I verified 'mvn clean install'. If there is no objection
until tomorrow, I'll commit this patch.
                  
> The package prefix should be org.apache.tajo.
> ---------------------------------------------
>
>                 Key: TAJO-22
>                 URL: https://issues.apache.org/jira/browse/TAJO-22
>             Project: Tajo
>          Issue Type: Task
>            Reporter: Hyunsik Choi
>            Assignee: DaeMyung Kang
>         Attachments: tajo-22.diff, TAJO-22.hyunsik.130702.patch.txt
>
>
> Now, the package prefix is just tajo. The package prefix should be org.apache.tajo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message