tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hls...@apache.org
Subject cvs commit: jakarta-tapestry/framework/src/net/sf/tapestry/enhance DefaultComponentClassEnhancer.java
Date Fri, 07 Feb 2003 04:22:34 GMT
hlship      2003/02/06 20:22:34

  Modified:    framework/src/net/sf/tapestry/enhance
                        DefaultComponentClassEnhancer.java
  Log:
  Correct minor bugs in the creation of properties for connected parameters.
  
  Revision  Changes    Path
  1.4       +8 -6      jakarta-tapestry/framework/src/net/sf/tapestry/enhance/DefaultComponentClassEnhancer.java
  
  Index: DefaultComponentClassEnhancer.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/framework/src/net/sf/tapestry/enhance/DefaultComponentClassEnhancer.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- DefaultComponentClassEnhancer.java	1 Feb 2003 16:46:42 -0000	1.3
  +++ DefaultComponentClassEnhancer.java	7 Feb 2003 04:22:34 -0000	1.4
  @@ -251,6 +251,12 @@
   
           PropertyDescriptor d = (PropertyDescriptor) beanProperties.get(propertyName);
   
  +        // If the property is entirely missing, then
  +        // assume it needs creation.
  +
  +        if (d == null)
  +            return true;
  +
           // No existing property matches, so we'll return true to
           // create an enhanced class with the property.
   
  @@ -315,7 +321,7 @@
   
               ParameterSpecification ps = specification.getParameter(name);
   
  -            createParameterProperty(cf, startClass, beanProperties, name, ps);
  +            createParameterProperty(cf, startClass, beanProperties, ps);
           }
   
           JavaClass jc = cf.commit();
  @@ -362,16 +368,12 @@
           ClassFabricator cf,
           Class beanClass,
           Map beanProperties,
  -        String parameterName,
           ParameterSpecification ps)
       {
           if (ps.getDirection() == Direction.CUSTOM)
               return;
   
           String propertyName = ps.getPropertyName();
  -
  -        if (propertyName == null)
  -            propertyName = parameterName;
   
           // Yes, but does it *need* a property created?
   
  
  
  

Mime
View raw message