tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hls...@apache.org
Subject cvs commit: jakarta-tapestry/framework/src/org/apache/tapestry/valid ValidField.jwc
Date Fri, 21 Mar 2003 19:01:26 GMT
hlship      2003/03/21 11:01:26

  Modified:    junit/mock-scripts TestTextField.xml
               doc/src/ComponentReference TextField.html ValidField.html
               junit/context17 Home.html
               framework/src/org/apache/tapestry/form
                        AbstractTextField.java TextField.jwc
               web      new.html
               framework/src/org/apache/tapestry/valid ValidField.jwc
  Log:
  Remove displayWidth and maximumLength parameters from TextField and ValidField.
  
  Revision  Changes    Path
  1.4       +3 -3      jakarta-tapestry/junit/mock-scripts/TestTextField.xml
  
  Index: TestTextField.xml
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/junit/mock-scripts/TestTextField.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- TestTextField.xml	18 Mar 2003 20:55:29 -0000	1.3
  +++ TestTextField.xml	21 Mar 2003 19:01:25 -0000	1.4
  @@ -17,7 +17,7 @@
   		
   		<assert-output name="Normal TextField">
   <![CDATA[
  -Normal: <input type="text" name="normal" size="20" maxlength="25" value="normal"/>
  +Normal: <input type="text" name="normal" value="normal"/>
   ]]>	
   		</assert-output>
   		
  @@ -75,7 +75,7 @@
   		
   		<assert-output name="Normal TextField">
   <![CDATA[
  -Normal: <input type="text" name="normal" size="20" maxlength="25" value="normal"/>
  +Normal: <input type="text" name="normal" value="normal"/>
   ]]>	
   		</assert-output>
   		
  
  
  
  1.9       +1 -23     jakarta-tapestry/doc/src/ComponentReference/TextField.html
  
  Index: TextField.html
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/doc/src/ComponentReference/TextField.html,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- TextField.html	6 Mar 2003 17:19:19 -0000	1.8
  +++ TextField.html	21 Mar 2003 19:01:25 -0000	1.9
  @@ -114,28 +114,6 @@
           Corresponds to the "disabled" HTML attribute.
       </td>
   	</tr>
  -	<tr>
  -		<td>displayWidth</td>
  -		<td>integer</td>
  -		<td>in</td>
  -		<td>no</td>
  -		<td>&nbsp;</td>
  -		<td>Controls the display width of the text control in the client browser. If
  -			unspecified or zero, then the width is left to the client browser to
  -			determine. Corresponds to the "size" HTML attribute.
  -    </td> 
  -  </tr>
  -	<tr>
  -		<td>maximumLength</td>
  -		<td>integer</td>
  -		<td>in</td>
  -		<td>no</td>
  -		<td>&nbsp;</td>
  -		<td>Controls the maximum characters that the text control will accept.  If
  -			unspecified or zero, then the value is left to the client browser to
  -			determine. Corresponds to the "maxlength" HTML attribute.
  -    </td> 
  -   </tr>
   	</table><BR>Body: 
               <STRONG>removed</STRONG><BR>Informal parameters: 
               <STRONG>allowed</STRONG>
  
  
  
  1.17      +12 -45    jakarta-tapestry/doc/src/ComponentReference/ValidField.html
  
  Index: ValidField.html
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/doc/src/ComponentReference/ValidField.html,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ValidField.html	21 Mar 2003 02:24:02 -0000	1.16
  +++ ValidField.html	21 Mar 2003 19:01:25 -0000	1.17
  @@ -207,30 +207,7 @@
       to the "disabled" HTML attribute.
      </td>
   	</tr>
  -	<tr>
  -	 <td>displayWidth</td>
  -	 <td>integer</td>
  -	 <td>in</td>
  -	 <td>no</td>
  -	 <td>&nbsp;</td>
  -	 <td>
  -   Controls the display width of the text control in the client browser.  If
  -	 unspecified or zero, then the width is left to the client browser to
  -	 determine. Corresponds to the "size" HTML attribute.
  -   </td> 
  -  </tr>
  -	<tr>
  -	 <td>maximumLength</td>
  -	 <td>integer</td>
  -   <td>in</td>
  -   <td>no</td>
  -	 <td>&nbsp;</td>
  -	 <td>
  -    Controls the maximum characters that the text control will accept.  If
  -		unspecified or zero, then the value is left to the client browser to
  -		determine. Corresponds to the "maxlength" HTML attribute.
  -   </td> 
  -  </tr>
  +
   	</table>
     <p>Body: <strong>removed</strong><br>
     Informal parameters:<strong>allowed</strong><br>
  @@ -305,19 +282,19 @@
    &lt;td colspan="2"&gt;&lt;span jwcid="@ShowError" delegate="ognl:beans.delegate"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
  - &lt;td&gt;Lot Number&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">lotNoField</span>" type="text"/&gt;&lt;/td&gt;
  + &lt;td&gt;Lot Number&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">lotNoField</span>" type="text" size="4" maxlength="4"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
  - &lt;td&gt;Bid Amount&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">bidAmountField</span>" type="text"/&gt;&lt;/td&gt;
  + &lt;td&gt;Bid Amount&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">bidAmountField</span>" type="text" size="7" maxlength="7"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
  - &lt;td&lt;Full Name&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">fullNameField</span>" type="text"/&gt;&lt;/td&gt;
  + &lt;td&lt;Full Name&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">fullNameField</span>" type="text" size="25" maxlength="30"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
  - &lt;td&gt;Email&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">emailField</span>" type="text"/&gt;&lt;/td&gt;
  + &lt;td&gt;Email&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">emailField</span>" type="text" size="25" maxlength="30"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
  - &lt;td&gt;Telphone&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">telephoneField</span>" type="text"/&gt;&lt;/td&gt;
  + &lt;td&gt;Telphone&lt;/td&gt;&lt;td&gt;&lt;input jwcid="<span
class="jwcid">telephoneField</span>" type="text" size="25" maxlength="30"/&gt;&lt;/td&gt;
   &lt;/tr&gt;
   &lt;tr&gt;
    &lt;td colspan="2" align="right"&gt;
  @@ -363,41 +340,31 @@
   &lt;component id="<span class="jwcid">lotNoField</span>" type="<A href="ValidField.html">ValidField</a>"&gt;
       &lt;binding name="value" expression="lotBid.lotNo"/&gt;
       &lt;binding name="validator" expression="beans.lotNoValidator"/&gt;
  -    &lt;binding name="displayName" expression='"Lot Number"'/&gt;
  -    &lt;binding name="displayWidth" expression="4"/&gt;
  -    &lt;binding name="maximumLength" expression="4"/&gt;
  +    &lt;static-binding name="displayName" value="Lot Number"/&gt;
   &lt;/component&gt;
   
   &lt;component id="<span class="jwcid">bidAmountField</span>" type="<A
href="ValidField.html">ValidField</a>"&gt;
       &lt;binding name="value" expression="lotBid.bidAmount"/&gt;
       &lt;binding name="validator" expression="beans.bidAmountNoValidator"/&gt;
  -    &lt;binding name="displayName" expression='"Bid Amount"'/&gt;
  -    &lt;binding name="displayWidth" expression="7"/&gt;
  -    &lt;binding name="maximumLength" expression="7"/&gt;
  +    &lt;static-binding name="displayName" value="Bid Amount"/&gt;
   &lt;/component&gt;
   
   &lt;component id="<span class="jwcid">fullNameField</span>" type="<A
href="ValidField.html">ValidField</a>"&gt;
       &lt;binding name="value" expression="lotBid.bidderName"/&gt;
       &lt;binding name="validator" expression="beans.fullNameValidator"/&gt;
  -    &lt;binding name="displayName" expression='"Full Name"'/&gt;
  -    &lt;binding name="displayWidth" expression="25"/&gt;
  -    &lt;binding name="maximumLength" expression="30"/&gt;
  +    &lt;static-binding name="displayName" value="Full Name"/&gt;
   &lt;/component&gt;
   
   &lt;component id="<span class="jwcid">emailField</span>" type="<A href="ValidField.html">ValidField</a>"&gt;
       &lt;binding name="value" expression="lotBid.bidderEmail"/&gt;
       &lt;binding name="validator" expression="beans.emailValidator"/&gt;
  -    &lt;binding name="displayName" expression='"Email"'/&gt;
  -    &lt;binding name="displayWidth" expression="25"/&gt;
  -    &lt;binding name="maximumLength" expression="30"/&gt;
  +    &lt;static-binding name="displayName" value="Email"/&gt;
   &lt;/component&gt;
   
   &lt;component id="<span class="jwcid">telephoneField</span>" type="<A
href="ValidField.html">ValidField</a>"&gt;
       &lt;binding name="value" expression="lotBid.bidderTelephone"/&gt;
       &lt;binding name="validator" expression="beans.telephoneValidator"/&gt;
  -    &lt;binding name="displayName" expression='"Telephone"'/&gt;
  -    &lt;binding name="displayWidth" expression="25"/&gt;
  -    &lt;binding name="maximumLength" expression="30"/&gt;
  +    &lt;static-binding name="displayName" value="Telephone"/&gt;;
   &lt;/component&gt;
   
   
  
  
  
  1.3       +1 -1      jakarta-tapestry/junit/context17/Home.html
  
  Index: Home.html
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/junit/context17/Home.html,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Home.html	5 Mar 2003 23:20:09 -0000	1.2
  +++ Home.html	21 Mar 2003 19:01:25 -0000	1.3
  @@ -2,7 +2,7 @@
   <body jwcid="@Body">
   
   <form jwcid="@Form" listener="ognl:listeners.formSubmit">
  -Normal: <input jwcid="normal@TextField" value="ognl:normal" displayWidth="20" maximumLength="25"/>
  +Normal: <input jwcid="normal@TextField" value="ognl:normal"/>
   <br/>
   Disabled: <input jwcid="disabled@TextField" value="ognl:disabled" disabled="ognl:true"/>
   <br/>
  
  
  
  1.4       +1 -14     jakarta-tapestry/framework/src/org/apache/tapestry/form/AbstractTextField.java
  
  Index: AbstractTextField.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/framework/src/org/apache/tapestry/form/AbstractTextField.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- AbstractTextField.java	17 Mar 2003 18:10:48 -0000	1.3
  +++ AbstractTextField.java	21 Mar 2003 19:01:25 -0000	1.4
  @@ -121,15 +121,6 @@
   
           writer.attribute("name", name);
   
  -		int displayWidth = getDisplayWidth();
  -		int maximumLength = getMaximumLength();
  -
  -        if (displayWidth != 0)
  -            writer.attribute("size", displayWidth);
  -
  -        if (maximumLength != 0)
  -            writer.attribute("maxlength", maximumLength);
  -
           value = readValue();
           if (value != null)
               writer.attribute("value", value);
  @@ -174,8 +165,4 @@
       public abstract boolean isHidden();
   
       public abstract boolean isDisabled();
  -
  -    public abstract int getDisplayWidth();
  -
  -    public abstract int getMaximumLength();
   }
  
  
  
  1.3       +1 -5      jakarta-tapestry/framework/src/org/apache/tapestry/form/TextField.jwc
  
  Index: TextField.jwc
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/framework/src/org/apache/tapestry/form/TextField.jwc,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- TextField.jwc	17 Mar 2003 18:10:48 -0000	1.2
  +++ TextField.jwc	21 Mar 2003 19:01:25 -0000	1.3
  @@ -16,10 +16,6 @@
     
     <parameter name="hidden" type="boolean" direction="in"/>
     
  -  <parameter name="displayWidth" type="int" direction="in"/>
  -  
  -  <parameter name="maximumLength" type="int" direction="in"/>
  -  
     <reserved-parameter name="type"/>
     <reserved-parameter name="value"/>
     
  
  
  
  1.139     +4 -2      jakarta-tapestry/web/new.html
  
  Index: new.html
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/web/new.html,v
  retrieving revision 1.138
  retrieving revision 1.139
  diff -u -r1.138 -r1.139
  --- new.html	18 Mar 2003 20:55:32 -0000	1.138
  +++ new.html	21 Mar 2003 19:01:26 -0000	1.139
  @@ -28,7 +28,9 @@
   to runtime objects and exceptions for error reporting purposes.</li>
   <li>Severely refactored exceptions, removing many exception classes and flattening
all others
    under ApplicationRuntimeException.</li>
  -<li>Simplified the URL format, merging the "service" and "context" parameters together.
  +<li>Simplified the URL format, merging the "service" and "context" parameters together.</li>
  +<li>Removed the "width" and "displayWidth" and "maxLength" parameters from TextField
and ValidField
  +(HTML attributes "size" and "maxlength", as informal parameters, are sufficient).</li>
   </ul>
   
   <h3>Release 2.4-alpha-4</h3>
  
  
  
  1.3       +2 -7      jakarta-tapestry/framework/src/org/apache/tapestry/valid/ValidField.jwc
  
  Index: ValidField.jwc
  ===================================================================
  RCS file: /home/cvs/jakarta-tapestry/framework/src/org/apache/tapestry/valid/ValidField.jwc,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ValidField.jwc	17 Mar 2003 18:10:50 -0000	1.2
  +++ ValidField.jwc	21 Mar 2003 19:01:26 -0000	1.3
  @@ -15,12 +15,7 @@
     <parameter name="disabled" type="boolean" direction="in"/>
     
     <parameter name="hidden" type="boolean" direction="in"/>
  -  
  -  <parameter name="displayWidth" type="int" direction="in"/>
  -  
  -  <parameter name="maximumLength" type="int" direction="in"/>
  -  
  -  
  +    
     <parameter name="validator" type="org.apache.tapestry.valid.IValidator" required="yes"
direction="in">
       <description>
       Converts value to a string and parses strings back into object values.
  
  
  

Mime
View raw message