tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <e...@ehatchersolutions.com>
Subject Fwd: cvs commit: jakarta-tapestry/junit/src/org/apache/tapestry/junit TestBindings.java
Date Tue, 25 Nov 2003 14:20:07 GMT
I'm not sure if my changes to the catch clauses are proper or not, but 
catching Throwable seemed a bit overkill.  But maybe elsewhere the 
system relies on the wrapping of things other than OgnlException into a 
BindingException.

If I'm wrong in making this exception handling change, please let me 
know and explain to me more about why it's incorrect.

Thanks,
	Erik


Begin forwarded message:
>   Index: ExpressionBinding.java
>   @@ -239,7 +241,7 @@
>            {
>                return Ognl.getValue(_parsedExpression, 
> getOgnlContext(), _root);
>            }
>   -        catch (Throwable t)
>   +        catch (OgnlException t)
>            {
>   @@ -417,7 +438,7 @@
>                    return true;
>                }
>            }
>   -        catch (Exception ex)
>   +        catch (OgnlException ex)
>            {
>                throw new BindingException(
>                    Tapestry.format(
>   @@ -560,7 +581,7 @@
>            {
>                Ognl.setValue(_parsedExpression, getOgnlContext(), 
> _root, value);
>            }
>   -        catch (Throwable ex)
>   +        catch (OgnlException ex)


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Mime
View raw message