tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mind Bridge <mindbridge...@yahoo.com>
Subject RE: Table component changes checked in
Date Mon, 29 Dec 2003 19:58:02 GMT

--- "Howard M. Lewis Ship" <hlship@comcast.net> wrote:
> > A few other things:
> > - Shouldn't the 'type' attribute of <parameter> in
> the 
> > component specs be required? Or perhaps have it
> default to 
> > java.lang.Object?
> 
> That's how I thought it worked. It doesn't?

So did I, actually, but I think the testing with my
private JUnit tests (for Table) seemed to show
otherwise, which surprised me a bit. Perhaps I was
mistaken -- will check again when I come back.

> > - should the string 'true' evaluate to the boolean
> value of 
> > TRUE? In that way the common mistake of writing
> 'true' rather 
> > than 'ognl:true' will not be a problem.
> 
> Any non-null string should evaluate to true.  The
> problem is that 'false' also evaluates to true,
> since it is also a non-null string. This is a very,
> very common error ... perhaps we should special
> case 'false' to evaluate to true (inside
> Tapestry.evaluateBoolean() ) ?

I am +1 on that.

Thanks and all the best,
-mb


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Mime
View raw message