tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hls...@apache.org
Subject svn commit: r279446 - in /jakarta/tapestry/trunk: ./ contrib/src/java/org/apache/tapestry/contrib/ contrib/src/java/org/apache/tapestry/contrib/components/ contrib/src/java/org/apache/tapestry/contrib/inspector/ framework/src/documentation/content/xdoc...
Date Wed, 07 Sep 2005 22:32:53 GMT
Author: hlship
Date: Wed Sep  7 15:32:25 2005
New Revision: 279446

URL: http://svn.apache.org/viewcvs?rev=279446&view=rev
Log:
TAPESTRY-240: XHTML 1.0 Strict compliance

Added:
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/components/DumpObject.jwc
    jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/html/TestImage.java
Modified:
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/Contrib.library
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.css
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.library
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Selector.html
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowEngine.html
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowSpecification.html
    jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ViewTabs.html
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Conditional.xml
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/DirectLink.xml
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/PageLink.xml
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Select.xml
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/ExceptionDisplay.html
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.jwc
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.jwc
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/util/PageRenderSupportImpl.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/wml/GoFormSupportImpl.java
    jakarta/tapestry/trunk/framework/src/scripts/TestAssetService.xml
    jakarta/tapestry/trunk/framework/src/scripts/TestInheritInformalParameters.xml
    jakarta/tapestry/trunk/framework/src/test-data/context24/Home.html
    jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/BaseComponentTestCase.java
    jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/TestFormSupport.java
    jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/util/TestPageRenderSupport.java
    jakarta/tapestry/trunk/src/documentation/content/xdocs/UsersGuide/upgrade.xml
    jakarta/tapestry/trunk/status.xml

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/Contrib.library
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/Contrib.library?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/Contrib.library (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/Contrib.library Wed Sep  7 15:32:25 2005
@@ -28,6 +28,7 @@
   <library id="inspector" specification-path="inspector/Inspector.library"/>
   <component-type type="Choose" specification-path="components/Choose.jwc"/>
   <component-type type="When" specification-path="components/When.jwc"/>
+  <component-type type="DumpObject" specification-path="components/DumpObject.jwc"/>
   <component-type type="Otherwise" specification-path="components/Otherwise.jwc"/>
   <component-type type="Palette" specification-path="palette/Palette.jwc"/>
   <component-type type="MultiplePropertySelection" specification-path="form/MultiplePropertySelection.jwc"/>

Added: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/components/DumpObject.jwc
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/components/DumpObject.jwc?rev=279446&view=auto
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/components/DumpObject.jwc (added)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/components/DumpObject.jwc Wed Sep  7 15:32:25 2005
@@ -0,0 +1,34 @@
+<?xml version="1.0"?>
+<!-- 
+   Copyright 2005 The Apache Software Foundation
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<!DOCTYPE component-specification PUBLIC 
+  "-//Apache Software Foundation//Tapestry Specification 4.0//EN" 
+  "http://jakarta.apache.org/tapestry/dtd/Tapestry_4_0.dtd">
+
+<component-specification allow-body="no" allow-informal-parameters="yes">
+
+  <description>
+    Displays the properties of an object as an HTML table or a simple string.
+  </description> 
+  
+  <parameter name="object" required="true">
+    <description>
+      The object to be displayed as HTML.
+    </description>
+  </parameter>
+ 
+</component-specification>
\ No newline at end of file

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.css
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.css?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.css (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.css Wed Sep  7 15:32:25 2005
@@ -25,6 +25,11 @@
 	font-family: "Trebuchet MS", sans-serif;
 }
 
+A IMG
+{
+  border: none;
+}
+
 
 TABLE.inspector-data
 {
@@ -266,4 +271,5 @@
 {
   text-align: right;
   width: 1px; // Will stretch to fit.
-}
\ No newline at end of file
+}
+

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.library
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.library?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.library (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Inspector.library Wed Sep  7 15:32:25 2005
@@ -23,7 +23,7 @@
   <!-- Turns out that libraries have to form a tree; since this library is included by Contrib, it can't include Contrib.  Instead,
        we shadow a component from it. Sloppy and probably a bug. -->
        
-  <component-type type="DumpObject" specification-path="/org/apache/tapestry/contrib/DumpObject.jwc"/>
+  <component-type type="DumpObject" specification-path="/org/apache/tapestry/contrib/components/DumpObject.jwc"/>
   
   <meta key="org.apache.tapestry.component-class-packages" value="org.apache.tapestry.contrib.components"/>
   

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Selector.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Selector.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Selector.html (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/Selector.html Wed Sep  7 15:32:25 2005
@@ -16,7 +16,7 @@
 
 <span jwcid="$content$">
 <table class="selector">
-	<tr valign=center>
+	<tr valign="middle">
 		<td>
 			<form jwcid="form">
 				<select jwcid="selectPage"/>

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowEngine.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowEngine.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowEngine.html (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowEngine.html Wed Sep  7 15:32:25 2005
@@ -18,7 +18,7 @@
 <table class="inspector-data">
 
 	<tr class="heading">
-		<th colspan=2>Engine/Application Properties</th>
+		<th colspan="2">Engine/Application Properties</th>
 	</tr>
 	
 	<tr class="heading">

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowSpecification.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowSpecification.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowSpecification.html (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ShowSpecification.html Wed Sep  7 15:32:25 2005
@@ -52,7 +52,7 @@
 
 <table class="inspector-data" width="100%">
 	<tr class="heading">
-		<th colspan=4>Formal Parameters</th>
+		<th colspan="4">Formal Parameters</th>
 	</tr>
 	<tr class="heading">
 		<th>Name</th> <th>Required</th> <th>Java type</th> <th>Binding</th>
@@ -74,7 +74,7 @@
 
 <table class="inspector-data" width="100%">
 	<tr class="heading">
-		<th colspan=2>Informal Parameters</th>
+		<th colspan="2">Informal Parameters</th>
 	</tr>
 	<tr class="heading">
 		<th>Name</th> <th>Binding</th>
@@ -92,7 +92,7 @@
 
 <table class="inspector-data"  width="100%">
 	<tr class="heading">
-		<th colspan=2>Assets</th>
+		<th colspan="2">Assets</th>
 	</tr>
 	<tr class="heading">
 		<th>Name</th> <th>Asset</th>
@@ -111,7 +111,7 @@
 
 <table class="inspector-data" width="100%">
 	<tr class="heading">
-		<th colspan=2>Properties</th>
+		<th colspan="2">Properties</th>
 	</tr>
 	<tr class="heading">
 		<th>Name</th> <th>Property</th>
@@ -129,7 +129,7 @@
 
 <table class="inspector-data" width="100%">
 	<tr class="heading">
-		<th colspan=3>Helper Beans</th>
+		<th colspan="3">Helper Beans</th>
 	</tr>
 	
 	<tr class="heading">
@@ -153,7 +153,7 @@
 <table border="0" class="inspector-data">
 
 	<tr class="heading">
-		<th colspan=2>Embedded Components</th>
+		<th colspan="2">Embedded Components</th>
 	</tr>
 	<tr class="heading">
 		<th>Id</th> <th>Type</th>

Modified: jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ViewTabs.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ViewTabs.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ViewTabs.html (original)
+++ jakarta/tapestry/trunk/contrib/src/java/org/apache/tapestry/contrib/inspector/ViewTabs.html Wed Sep  7 15:32:25 2005
@@ -15,7 +15,7 @@
 -->
 
 <span jwcid="$content$">
-<table border=0 cellpadding=0 cellspacing=2>
+<table border="0" cellpadding="0" cellspacing="2">
 	<tr>
 		<td>
 <span jwcid="@Foreach" source="ognl:views" value="ognl:view">

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml Wed Sep  7 15:32:25 2005
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!--
+<!-- 
    Copyright 2004, 2005 The Apache Software Foundation
 
    Licensed under the Apache License, Version 2.0 (the "License");

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Conditional.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Conditional.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Conditional.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Conditional.xml Wed Sep  7 15:32:25 2005
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!--
+<!-- 
    Copyright 2004, 2005 The Apache Software Foundation
 
    Licensed under the Apache License, Version 2.0 (the "License");

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/DirectLink.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/DirectLink.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/DirectLink.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/DirectLink.xml Wed Sep  7 15:32:25 2005
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!--
+<!-- 
    Copyright 2004, 2005 The Apache Software Foundation
 
    Licensed under the Apache License, Version 2.0 (the "License");

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/PageLink.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/PageLink.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/PageLink.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/PageLink.xml Wed Sep  7 15:32:25 2005
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!--
+<!-- 
    Copyright 2004, 2005 The Apache Software Foundation
 
    Licensed under the Apache License, Version 2.0 (the "License");

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Select.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Select.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Select.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/Select.xml Wed Sep  7 15:32:25 2005
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<!--
+<!-- 
    Copyright 2004, 2005 The Apache Software Foundation
 
    Licensed under the Apache License, Version 2.0 (the "License");

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java Wed Sep  7 15:32:25 2005
@@ -486,7 +486,6 @@
 
         _writer.println();
 
-        writeHiddenField(FORM_IDS, null, buildAllocatedIdList());
         writeHiddenFields();
 
         // Close the nested writer, inserting its contents.
@@ -591,6 +590,9 @@
         _encodingType = encodingType;
     }
 
+    /**
+     * Overwridden by {@link org.apache.tapestry.wml.GoFormSupportImpl} (WML).
+     */
     protected void writeHiddenField(IMarkupWriter writer, String name, String id, String value)
     {
         writer.beginEmpty("input");
@@ -611,11 +613,29 @@
 
     /**
      * Writes out all hidden values previously added by
-     * {@link #addHiddenValue(String, String, String)}.
+     * {@link #addHiddenValue(String, String, String)}. Writes a &lt;div&gt; tag around
+     * {@link #writeHiddenFieldList()}. Overriden by
+     * {@link org.apache.tapestry.wml.GoFormSupportImpl}.
      */
 
-    private void writeHiddenFields()
+    protected void writeHiddenFields()
     {
+        _writer.begin("div");
+
+        writeHiddenFieldList();
+
+        _writer.end();
+    }
+
+    /**
+     * Writes out all hidden values previously added by
+     * {@link #addHiddenValue(String, String, String)}, plus the allocated id list.
+     */
+
+    protected void writeHiddenFieldList()
+    {
+        writeHiddenField(FORM_IDS, null, buildAllocatedIdList());
+
         Iterator i = _hiddenValues.iterator();
         while (i.hasNext())
         {

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/ExceptionDisplay.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/ExceptionDisplay.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/ExceptionDisplay.html (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/ExceptionDisplay.html Wed Sep  7 15:32:25 2005
@@ -39,7 +39,7 @@
 		</tr>		
 		
 <span jwcid="ifNotLast">
-		<tr> <td colspan=2> &nbsp; </td> </tr>
+		<tr> <td colspan="2"> &nbsp; </td> </tr>
 </span>
 	
 <span jwcid="ifLast">
@@ -48,7 +48,7 @@
 		</tr>
 
 		<tr class="stack-trace">
-			<td colspan=2>
+			<td colspan="2">
 				<ul>
 					<li jwcid="eStack"><span jwcid="insertStackTrace">foo.bar.baz(Line:xyz)</span>
 					</li>

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.java Wed Sep  7 15:32:25 2005
@@ -21,24 +21,18 @@
 import org.apache.tapestry.Tapestry;
 
 /**
- *  Used to insert an image.  To create a rollover image, use the
- *  {@link Rollover} class, which integrates a link with the image assets
- *  used with the button.
- *
- *  [<a href="../../../../../ComponentReference/Image.html">Component Reference</a>]
- *
- *
- *  @author Howard Lewis Ship
+ * Used to insert an image. To create a rollover image, use the {@link Rollover} class, which
+ * integrates a link with the image assets used with the button. [<a
+ * href="../../../../../ComponentReference/Image.html">Component Reference</a>]
  * 
- **/
+ * @author Howard Lewis Ship
+ */
 
 public abstract class Image extends AbstractComponent
 {
     /**
-     *  Renders the &lt;img&gt; element.
-     *
-     *
-     **/
+     * Renders the &lt;img&gt; element.
+     */
 
     protected void renderComponent(IMarkupWriter writer, IRequestCycle cycle)
     {
@@ -59,15 +53,10 @@
 
         writer.attribute("src", imageURL);
 
-        writer.attribute("border", getBorder());
-
         renderInformalParameters(writer, cycle);
 
         writer.closeTag();
-
     }
 
     public abstract IAsset getImage();
-
-    public abstract int getBorder();
 }

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.jwc
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.jwc?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.jwc (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Image.jwc Wed Sep  7 15:32:25 2005
@@ -31,12 +31,6 @@
     </description>
   </parameter>
   
-  <parameter name="border">
-    <description>
-    Number of pixels of border.
-    </description>
-  </parameter>
-  
   <reserved-parameter name="src"/>
   
 </component-specification>

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.java Wed Sep  7 15:32:25 2005
@@ -18,10 +18,8 @@
 import java.util.Map;
 
 import org.apache.hivemind.ApplicationRuntimeException;
-import org.apache.hivemind.Resource;
 import org.apache.tapestry.AbstractComponent;
 import org.apache.tapestry.IAsset;
-import org.apache.tapestry.IEngine;
 import org.apache.tapestry.IMarkupWriter;
 import org.apache.tapestry.IRequestCycle;
 import org.apache.tapestry.IScript;
@@ -30,7 +28,6 @@
 import org.apache.tapestry.TapestryUtils;
 import org.apache.tapestry.components.ILinkComponent;
 import org.apache.tapestry.components.LinkEventType;
-import org.apache.tapestry.engine.IScriptSource;
 
 /**
  * Combines a link component (such as {@link org.apache.tapestry.link.DirectLink}) with an
@@ -43,8 +40,6 @@
 
 public abstract class Rollover extends AbstractComponent
 {
-    private IScript _parsedScript;
-
     /**
      * Converts an {@link IAsset}binding into a usable URL. Returns null if the binding does not
      * exist or the binding's value is null.
@@ -106,8 +101,6 @@
 
         writer.attribute("src", imageURL);
 
-        writer.attribute("border", 0);
-
         if (dynamic)
         {
             if (focusURL == null)
@@ -127,21 +120,9 @@
 
     }
 
-    private IScript getParsedScript()
-    {
-        if (_parsedScript == null)
-        {
-            IEngine engine = getPage().getEngine();
-            IScriptSource source = engine.getScriptSource();
-
-            Resource scriptLocation = getSpecification().getSpecificationLocation()
-                    .getRelativeResource("Rollover.script");
-
-            _parsedScript = source.getScript(scriptLocation);
-        }
+    // Injected
 
-        return _parsedScript;
-    }
+    public abstract IScript getScript();
 
     private String writeScript(IRequestCycle cycle, PageRenderSupport pageRenderSupport,
             ILinkComponent link, String focusURL, String blurURL)
@@ -156,7 +137,7 @@
         symbols.put("focusImageURL", focusImageURL);
         symbols.put("blurImageURL", blurImageURL);
 
-        getParsedScript().execute(cycle, pageRenderSupport, symbols);
+        getScript().execute(cycle, pageRenderSupport, symbols);
 
         // Add attributes to the link to control mouse over/out.
         // Because the script is written before the <body> tag,

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.jwc
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.jwc?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.jwc (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/html/Rollover.jwc Wed Sep  7 15:32:25 2005
@@ -56,6 +56,7 @@
   
   <reserved-parameter name="name"/>
   <reserved-parameter name="src"/>
-  <reserved-parameter name="border"/>
   
-</component-specification>
+  <inject property="script" type="script" object="Rollover.script"/>
+  
+</component-specification>
\ No newline at end of file

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/util/PageRenderSupportImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/util/PageRenderSupportImpl.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/util/PageRenderSupportImpl.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/util/PageRenderSupportImpl.java Wed Sep  7 15:32:25 2005
@@ -175,7 +175,6 @@
             // interpret <script .../> properly.
 
             writer.begin("script");
-            writer.attribute("language", "JavaScript");
             writer.attribute("type", "text/javascript");
             writer.attribute("src", url);
             writer.end();
@@ -203,7 +202,6 @@
             return;
 
         writer.begin("script");
-        writer.attribute("language", "JavaScript");
         writer.attribute("type", "text/javascript");
         writer.printRaw("<!--");
 

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/wml/GoFormSupportImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/wml/GoFormSupportImpl.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/wml/GoFormSupportImpl.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/wml/GoFormSupportImpl.java Wed Sep  7 15:32:25 2005
@@ -42,6 +42,14 @@
         writer.attribute("href", url);
     }
 
+    protected void writeHiddenFields()
+    {
+        // The super-implementation writes a <div> tag that's not
+        // valid as WML.
+
+        writeHiddenFieldList();
+    }
+
     protected void writeHiddenField(IMarkupWriter writer, String name, String id, String value)
     {
         writer.beginEmpty("postfield");

Modified: jakarta/tapestry/trunk/framework/src/scripts/TestAssetService.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/scripts/TestAssetService.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/scripts/TestAssetService.xml (original)
+++ jakarta/tapestry/trunk/framework/src/scripts/TestAssetService.xml Wed Sep  7 15:32:25 2005
@@ -32,7 +32,7 @@
 		
 		<assert-output name="Image Tag">
 <![CDATA[
-<img src="/c16/app?digest=f6324ac8f24f0a7f4850221b0f14c865&amp;path=%2Forg%2Fapache%2Ftapestry%2Fjunit%2Fmock%2Fc16%2Flogo.png&amp;service=asset" border="0"/>
+<img src="/c16/app?digest=f6324ac8f24f0a7f4850221b0f14c865&amp;path=%2Forg%2Fapache%2Ftapestry%2Fjunit%2Fmock%2Fc16%2Flogo.png&amp;service=asset"/>
 ]]>
 		</assert-output>
 	</request>

Modified: jakarta/tapestry/trunk/framework/src/scripts/TestInheritInformalParameters.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/scripts/TestInheritInformalParameters.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/scripts/TestInheritInformalParameters.xml (original)
+++ jakarta/tapestry/trunk/framework/src/scripts/TestInheritInformalParameters.xml Wed Sep  7 15:32:25 2005
@@ -31,10 +31,6 @@
 		src="http://the.wall/"
 		</assert-output>
 		
-		<assert-output name="border">
-		border="0"
-		</assert-output>
-		
 		<assert-output name="width">
 		width="250"
 		</assert-output>
@@ -47,9 +43,9 @@
 		length="350"
 		</assert-output>
 
-		<assert-no-output name="no-border">
+		<assert-output name="no-border">
 		border="7"
-		</assert-no-output>
+		</assert-output>
 
 		<assert-no-output name="no-src">
 		src="testSrc"

Modified: jakarta/tapestry/trunk/framework/src/test-data/context24/Home.html
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test-data/context24/Home.html?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test-data/context24/Home.html (original)
+++ jakarta/tapestry/trunk/framework/src/test-data/context24/Home.html Wed Sep  7 15:32:25 2005
@@ -1,10 +1,6 @@
 <html jwcid="@Shell" title="Home">
 <body>
 
-<!-- border=7 			must NOT be passed down to Image, since it is a formal parameter in Image -->
-<!-- src=testSrc 		must NOT be passed down to Image, since it is a reserved parameter in Image -->
-<!-- class=testClass 	must NOT be passed down to Image, since it is a reserved parameter in SuperImage -->
-<!-- height=150			must be passed down to Image as an inherited informal parameter -->
 <span jwcid="superImage" border="7" src="testSrc" class="testClass" height="150"/>
 	
 </body>

Modified: jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/BaseComponentTestCase.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/BaseComponentTestCase.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/BaseComponentTestCase.java (original)
+++ jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/BaseComponentTestCase.java Wed Sep  7 15:32:25 2005
@@ -19,15 +19,6 @@
 
 import org.apache.hivemind.Location;
 import org.apache.hivemind.test.HiveMindTestCase;
-import org.apache.tapestry.IBinding;
-import org.apache.tapestry.IComponent;
-import org.apache.tapestry.IForm;
-import org.apache.tapestry.IMarkupWriter;
-import org.apache.tapestry.IPage;
-import org.apache.tapestry.IRender;
-import org.apache.tapestry.IRequestCycle;
-import org.apache.tapestry.PageRenderSupport;
-import org.apache.tapestry.TapestryUtils;
 import org.apache.tapestry.markup.AsciiMarkupFilter;
 import org.apache.tapestry.markup.MarkupWriterImpl;
 import org.apache.tapestry.spec.IComponentSpecification;
@@ -275,6 +266,25 @@
 
         cycle.getParameter(name);
         control.setReturnValue(value);
+    }
+
+    protected void trainGetPageName(IPage page, String pageName)
+    {
+        page.getPageName();
+
+        getControl(page).setReturnValue(pageName);
+    }
+
+    protected void trainBuildURL(IAsset asset, IRequestCycle cycle, String URL)
+    {
+        asset.buildURL(cycle);
+
+        getControl(asset).setReturnValue(URL);
+    }
+
+    protected IAsset newAsset()
+    {
+        return (IAsset) newMock(IAsset.class);
     }
 
 }

Modified: jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/TestFormSupport.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/TestFormSupport.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/TestFormSupport.java (original)
+++ jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/TestFormSupport.java Wed Sep  7 15:32:25 2005
@@ -184,10 +184,14 @@
 
         writer.println();
 
+        writer.begin("div");
+        
         trainHidden(writer, "formids", "barney,wilma,barney_0");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -375,10 +379,14 @@
 
         writer.println();
 
+        writer.begin("div");
+        
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -475,10 +483,14 @@
 
         writer.println();
 
+        writer.begin("div");
+        
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -571,12 +583,16 @@
 
         writer.println();
 
+        writer.begin("div");
+
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
         trainHidden(writer, "hidden1", "value1");
         trainHidden(writer, "hidden2", "id2", "value2");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -746,11 +762,15 @@
 
         writer.println();
 
+        writer.begin("div");
+ 
         trainHidden(writer, "formids", "action_0");
         trainHidden(writer, "action", "fred");
         trainHidden(writer, "reservedids", "action");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -843,10 +863,14 @@
 
         writer.println();
 
+        writer.begin("div");
+
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -1192,10 +1216,14 @@
 
         writer.println();
 
+        writer.begin("div");
+
         trainHidden(writer, "formids", "barney");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();
@@ -1303,10 +1331,14 @@
 
         writer.println();
 
+        writer.begin("div");
+
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         // EasyMock can't fully verify that this gets called at the right moment, nor can we truly
         // prove (well, except by looking at the code), that the deferred runnables execute at the
         // right time.
@@ -1611,10 +1643,14 @@
 
         writer.println();
 
+        writer.begin("div");
+
         trainHidden(writer, "formids", "");
         trainHidden(writer, "service", "fred");
         trainHidden(writer, "submitmode", "");
 
+        writer.end();
+        
         nested.close();
 
         writer.end();

Added: jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/html/TestImage.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/html/TestImage.java?rev=279446&view=auto
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/html/TestImage.java (added)
+++ jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/html/TestImage.java Wed Sep  7 15:32:25 2005
@@ -0,0 +1,113 @@
+// Copyright 2005 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry.html;
+
+import org.apache.hivemind.ApplicationRuntimeException;
+import org.apache.hivemind.Location;
+import org.apache.tapestry.BaseComponentTestCase;
+import org.apache.tapestry.IAsset;
+import org.apache.tapestry.IBinding;
+import org.apache.tapestry.IMarkupWriter;
+import org.apache.tapestry.IPage;
+import org.apache.tapestry.IRequestCycle;
+import org.apache.tapestry.spec.IComponentSpecification;
+
+/**
+ * Tests for {@link org.apache.tapestry.html.Image} component.
+ * 
+ * @author Howard M. Lewis Ship
+ * @since 4.0
+ */
+public class TestImage extends BaseComponentTestCase
+{
+    public void testRewinding()
+    {
+        IMarkupWriter writer = newWriter();
+        IRequestCycle cycle = newCycle();
+
+        trainIsRewinding(cycle, true);
+
+        Image image = (Image) newInstance(Image.class);
+
+        replayControls();
+
+        image.renderComponent(writer, cycle);
+
+        verifyControls();
+    }
+
+    public void testNoImage()
+    {
+        Location l = newLocation();
+        IMarkupWriter writer = newWriter();
+        IRequestCycle cycle = newCycle();
+        IPage page = newPage();
+
+        trainIsRewinding(cycle, false);
+
+        trainGetPageName(page, "Fred");
+        trainGetIdPath(page, null);
+
+        Image image = (Image) newInstance(Image.class, new Object[]
+        { "location", l, "id", "barney", "page", page, "container", page });
+
+        replayControls();
+
+        try
+        {
+            image.renderComponent(writer, cycle);
+        }
+        catch (ApplicationRuntimeException ex)
+        {
+            assertEquals(
+                    "Value for parameter 'image' in component Fred/barney is null, and a non-null value is required.",
+                    ex.getMessage());
+            assertSame(image, ex.getComponent());
+            assertSame(l, ex.getLocation());
+        }
+
+        verifyControls();
+    }
+
+    public void testRender()
+    {
+        IMarkupWriter writer = newWriter();
+        IRequestCycle cycle = newCycle();
+        IAsset asset = newAsset();
+        IBinding informal = newBinding("0");
+        IComponentSpecification spec = newSpec("border", null);
+
+        trainIsRewinding(cycle, false);
+
+        trainBuildURL(asset, cycle, "/foo.gif");
+
+        writer.beginEmpty("img");
+        writer.attribute("src", "/foo.gif");
+        writer.attribute("border", "0");
+
+        writer.closeTag();
+
+        replayControls();
+
+        Image image = (Image) newInstance(Image.class, new Object[]
+        { "image", asset, "specification", spec });
+
+        image.setBinding("border", informal);
+
+        image.renderComponent(writer, cycle);
+
+        verifyControls();
+    }
+}

Modified: jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/util/TestPageRenderSupport.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/util/TestPageRenderSupport.java?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/util/TestPageRenderSupport.java (original)
+++ jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/util/TestPageRenderSupport.java Wed Sep  7 15:32:25 2005
@@ -132,7 +132,7 @@
         prs.writeBodyScript(writer, cycle);
 
         assertOutput(new String[]
-        { "<script language=\"JavaScript\" type=\"text/javascript\"><!--", "",
+        { "<script type=\"text/javascript\"><!--", "",
                 "var tapestry_preload = new Array();", "if (document.images)", "{",
                 "  tapestry_preload[0] = new Image();",
                 "  tapestry_preload[0].src = \"/foo/bar.gif\";",
@@ -159,7 +159,7 @@
         prs.writeBodyScript(writer, cycle);
 
         assertOutput(new String[]
-        { "<script language=\"JavaScript\" type=\"text/javascript\"><!--", "",
+        { "<script type=\"text/javascript\"><!--", "",
                 "var NAMESPACE_preload = new Array();", "if (document.images)", "{",
                 "  NAMESPACE_preload[0] = new Image();",
                 "  NAMESPACE_preload[0].src = \"/foo/bar.gif\";", "}", "", "", "// --></script>" });
@@ -183,7 +183,7 @@
         prs.writeBodyScript(writer, cycle);
 
         assertOutput(new String[]
-        { "<script language=\"JavaScript\" type=\"text/javascript\"><!--", "", "myBodyScript();",
+        { "<script type=\"text/javascript\"><!--", "", "myBodyScript();",
                 "", "// --></script>" });
 
         verifyControls();
@@ -287,7 +287,7 @@
 
     private String scriptTagFor(String url)
     {
-        return "<script language=\"JavaScript\" type=\"text/javascript\" src=\"" + url
+        return "<script type=\"text/javascript\" src=\"" + url
                 + "\"></script>";
     }
 }

Modified: jakarta/tapestry/trunk/src/documentation/content/xdocs/UsersGuide/upgrade.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/src/documentation/content/xdocs/UsersGuide/upgrade.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/src/documentation/content/xdocs/UsersGuide/upgrade.xml (original)
+++ jakarta/tapestry/trunk/src/documentation/content/xdocs/UsersGuide/upgrade.xml Wed Sep  7 15:32:25 2005
@@ -397,5 +397,20 @@
   
 </section>
 
+<section id="upgrade.components">
+  <title>Changes to Components</title>
+  
+  <section>
+    <title>Image and Rollover</title>
+    
+    <p>
+      The border parameter of the &Image; and &Rollover; components has been removed, for XHTML compliance.
+      You may still specify a value for border as an informal parameter ... or better yet, handle this using CSS.
+    </p>
+      
+  </section>
+  
+</section>
+
 </body>
 </document>

Modified: jakarta/tapestry/trunk/status.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=279446&r1=279445&r2=279446&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Wed Sep  7 15:32:25 2005
@@ -24,13 +24,13 @@
     <person name="Richard Lewis-Shell" id="RLS"/>
     <person name="Mind Bridge" id="MB"/>
     <person name="Geoff Longman" id="GL"/>
-    <person name="Tsvetelin Saykov" id="TS"/>
     <person name="Paul Ferraro" email="pmf8@columbia.edu" id="PF"/>
     <!-- Add more people here -->
     <!-- Retired: -->
     <person name="Malcom Edgar" id="ME"/>
     <!-- Missing in action: -->
     <person name="Neil Clayton" id="NC"/>
+    <person name="Tsvetelin Saykov" id="TS"/>
   </developers>
   <todo>
     <actions priority="Release ???">
@@ -50,7 +50,7 @@
     -->
   </todo>
   <changes>
-    <release version="4.0-beta-6" date="unreleased">
+    <release version="4.0-beta-6" date="Sep 7 2005">
       <action type="update" dev="HLS" due-to="Henri Yandell">Convert Tapestry repository from CVS to SVN</action>
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-611">Pattern validator invokes wrong client-side JavaScript function</action>
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-610">$bean syntax for validators: binding prefix is broken</action>
@@ -71,6 +71,7 @@
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-546">Build uploads vlibbeans-xxx.jar to java repository (and thence to the maven repository)</action>
       <action type="fix" dev="DS" fixes-bug="TAPESTRY-461" due-to="Warner Onstine">Document DirectLink component</action>
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-600">Intermixing FieldLabels and form components can force a StaleLinkException</action>
+      <action type="fix" dev="HLS" fixes-bug="TAPESTRY-240">XHTML 1.0 Strict compliance</action>
     </release>
     <release version="4.0-beta-5" date="Aug 26 2005">
       <action type="fix" dev="MB,HLS" fixes-bug="TAPESTRY-552">Improperly configured SerializableAdaptor (for DataSqueezer) prevents serialized objects from being de-serialized</action>
@@ -441,101 +442,95 @@
     </release>
   </changes>
   <votes>
+    <vote title="Regular beta releases" date="Sep 3 2005" dev="HLS">
+      <motion>As per the ongoing discussion, this is a vote to introduce a new procedure: regular weekly beta releases until Tapestry 4.0 is ready for release. I will take primary responsibility for 
+        producing the release and the release announcements, though volunteers will also be welcome. Work will primarily occur on the weekend.</motion>
+      <response> HLS, DS, PF, HK, GL: +1 </response>
+    </vote>
     <vote title="Tapestry 4.0-beta-5" date="Aug 26 2005">
       <motion> Release early; release often. Lots of good fixes here, and I like releasing a beta every week or so. </motion>
       <response> HLS, PF, MB, RLS, GL, HK, DS: +1 </response>
     </vote>
-    <vote title="Tapestry 4.0-beta-4" date="Aug 9 2005">
-      <motion>
-        Since we've found and fixed a couple of real show-stopper bugs in
-beta-3, and its been a couple of weeks, I'd like to release beta-4.
-      </motion>
-      <response>
-        HLS, GL, HK, EH, DS, PF, RLS: +1
-      </response>
+    <vote title="Tapestry 4.0-beta-4" date="Aug 9 2005" dev="HLS">
+      <motion> Since we've found and fixed a couple of real show-stopper bugs in beta-3, and its been a couple of weeks, I'd like to release beta-4. </motion>
+      <response> HLS, GL, HK, EH, DS, PF, RLS: +1 </response>
     </vote>
     <vote title="Remove default-binding" dev="HLS" date="Jul 31 2005">
-      <motion>
-        OK ... this discussion has gone on long enough.  I'm willing to strip
-out the default-binding stuff and replace it with a simpler approach.
-Attributes will be intepreted as literals (unless prefixed) in the
-template, and as OGNL expressions (unless prefixed) elsewhere.
-
-This is a potentially de-stabilizing change; I am willing to do the
-work, but will expect others to pitch in and test (that is, pull down
-code and build apps against it), to help track down any latent errors.
-      </motion>
+      <motion> OK ... this discussion has gone on long enough. I'm willing to strip out the default-binding stuff and replace it with a simpler approach. Attributes will be intepreted as literals 
+        (unless prefixed) in the template, and as OGNL expressions (unless prefixed) elsewhere. This is a potentially de-stabilizing change; I am willing to do the work, but will expect others to 
+        pitch in and test (that is, pull down code and build apps against it), to help track down any latent errors. </motion>
       <response>HLS, RLS, EH, PF, GL, HK: +1</response>
     </vote>
     <vote title="Tapestry 4.0-beta-3" date="Jul 21 2005" dev="HLS">
-      <motion>Things have been cranking along, and we have a number of important
-fixes out there, and likely more by the time this vote completes.</motion>
+      <motion>Things have been cranking along, and we have a number of important fixes out there, and likely more by the time this vote completes.</motion>
       <response>HLS, PF, EH, DS, RLS, GL: +1</response>
     </vote>
     <vote title="Tapestry 4.0-beta-2" date="Jul 10 2005" dev="HLS">
-      <motion>Release early, release often.  Let's do a short vote and release
-beta-2 as soon as possible.</motion>
-<response>HLS, GL, EH, PF, DS, RLS, MB: +1</response>
+      <motion>Release early, release often. Let's do a short vote and release beta-2 as soon as possible.</motion>
+      <response>HLS, GL, EH, PF, DS, RLS, MB: +1</response>
     </vote>
     <vote title="Tapestry 4.0-beta-1" date="Jun 24 2005" dev="HLS">
-      <motion>I know this is unusual, but I'd like to make a vote pending some other
-developments.  I'm anxious to announce beta-1 when I'm at JavaOne.
-
-There are a couple of changes "in the queue" by various committers; I
-would like the first beta release to follow those changes being
-checked in.  MindBridge is readying his If and For components
-(form-aware version of Conditional and Foreach).  Paul is about to
-check in his improved validation support.  I will follow with some
-improvements to client-side event management.
-
-A +1 vote indicates a desire for the beta-1 release to follow these
-developments.  We can then focus on fixing bugs and documentation.
-</motion>
+      <motion>I know this is unusual, but I'd like to make a vote pending some other developments. I'm anxious to announce beta-1 when I'm at JavaOne. There are a couple of changes "in the queue" by 
+        various committers; I would like the first beta release to follow those changes being checked in. MindBridge is readying his If and For components (form-aware version of Conditional and 
+        Foreach). Paul is about to check in his improved validation support. I will follow with some improvements to client-side event management. A +1 vote indicates a desire for the beta-1 release 
+        to follow these developments. We can then focus on fixing bugs and documentation. </motion>
       <response>HLS, PF, EH, DS, HK, RLS: +1</response>
       <response>GL: +0</response>
     </vote>
     <vote title="Tapestry 4.0-alpha-3" date="May 12 2005" dev="HLS">
-      <motion>Although it hasn't been long since alpha-2, I'd like to release the next alpha of Tapestry 4.0. Why? A few things have settled down, some bugs have been fixed, a few really key features have been added, and I think the Portlet support is now complete.</motion>
+      <motion>Although it hasn't been long since alpha-2, I'd like to release the next alpha of Tapestry 4.0. Why? A few things have settled down, some bugs have been fixed, a few really key features 
+        have been added, and I think the Portlet support is now complete.</motion>
       <response>HLS, PF, HK, EH, RLS, DS, GL, TSV: +1</response>
     </vote>
     <vote title="Tapestry 4.0-alpha-2" date="May 5 2005" dev="HLS">
-      <motion> Now that HiveMind 1.1 has entered beta, I believe it's time to release a new alpha of Tapestry 4.0 (Picasso). This will give people a chance to see more of the (incomplete) Portlet support and many of the other recent fixes and improvements. </motion>
+      <motion> Now that HiveMind 1.1 has entered beta, I believe it's time to release a new alpha of Tapestry 4.0 (Picasso). This will give people a chance to see more of the (incomplete) Portlet 
+        support and many of the other recent fixes and improvements. </motion>
       <response>HLS, RLS, EH, TSV, DS, PF, GL, MB: +1</response>
     </vote>
     <vote title="Tapestry 4.0" date="Apr 15 2005" dev="HLS">
-      <motion>The sentiment of the community seems to be that the next major release of Tapestry (i.e., HiveMind infrastructure, Portlet support, etc.) is too different from Tapestry 3.0 to be called "Tapestry 3.1". This release will only be largely backwards compatible; applications that sub-class BaseEngine or make use of custom Tapestry engine services will require some amount of re-work. In a small number of cases, component parameters (espcially those using direction "auto" or "custom") 
-        will not work exactly as before. I feel it is completely reasonable to not call this release 3.1, but to continue to bend over backwards for backwards compatibility. A +1 vote signals that you concur, and that the next release should be numbered 4.0. This will affect the code in a very limited way: Much code has been added with a @since 3.1 javadoc tag; this will change to @since 4.,0. Likewise, the 3.1 numbering is in documentation, and inside some of the specification DTDs; these will 
-        also change. </motion>
+      <motion>The sentiment of the community seems to be that the next major release of Tapestry (i.e., HiveMind infrastructure, Portlet support, etc.) is too different from Tapestry 3.0 to be called 
+        "Tapestry 3.1". This release will only be largely backwards compatible; applications that sub-class BaseEngine or make use of custom Tapestry engine services will require some amount of 
+        re-work. In a small number of cases, component parameters (espcially those using direction "auto" or "custom") will not work exactly as before. I feel it is completely reasonable to not call 
+        this release 3.1, but to continue to bend over backwards for backwards compatibility. A +1 vote signals that you concur, and that the next release should be numbered 4.0. This will affect the 
+        code in a very limited way: Much code has been added with a @since 3.1 javadoc tag; this will change to @since 4.,0. Likewise, the 3.1 numbering is in documentation, and inside some of the 
+        specification DTDs; these will also change. </motion>
       <response>HLS, GL, PF, EH, DS, RLS: +1</response>
       <response>MB, HK, TSV: +0</response>
     </vote>
     <vote title="Tapestry 3.0.3" date="Mar 26 2005" dev="PF">
-      <motion> I finished patching/fixing all of the big issues identified with the last release. With any luck, this will be the last release for the 3.0 branch. This vote will run for one week. A +1 vote is to release Tapestry 3.0.3. I will be able to start the release once the votes are tallied. </motion>
+      <motion> I finished patching/fixing all of the big issues identified with the last release. With any luck, this will be the last release for the 3.0 branch. This vote will run for one week. A 
+        +1 vote is to release Tapestry 3.0.3. I will be able to start the release once the votes are tallied. </motion>
       <response> PF, HK, MB, HLS, TS, DS, EH, GL: +1 </response>
       <response> RLS: +0 </response>
     </vote>
     <vote title="Tapestry 3.1-alpha-1" date="Feb 15 2005" dev="HLS">
-      <motion>I think it's high time we provide people with a peek at 3.1. The code base has stabilized quite a bit in the last week or two, and although there's a huge amount of work to come, I think the community would benefit from an easy preview of what's coming. This will also be a chance to work through the release checklist I prepared last week.</motion>
+      <motion>I think it's high time we provide people with a peek at 3.1. The code base has stabilized quite a bit in the last week or two, and although there's a huge amount of work to come, I 
+        think the community would benefit from an easy preview of what's coming. This will also be a chance to work through the release checklist I prepared last week.</motion>
       <response>HLS, EH, HK, PF, RLS, DS, GL, TSV: +1 </response>
     </vote>
     <vote title="Tapestry 3.0.2" date="Feb 14 2005" dev="HLS">
-      <motion> I think we should just be done with 3.0.2. All the bugs that are going to get fixed, have been. The next version of OGNL should just drop in, and since its not shipped with the framework anyway, its not a big deal. </motion>
+      <motion> I think we should just be done with 3.0.2. All the bugs that are going to get fixed, have been. The next version of OGNL should just drop in, and since its not shipped with the 
+        framework anyway, its not a big deal. </motion>
       <response> HLS, PF, GL, RLS, DS, EH: +1 </response>
       <response> HK, TSV, MB: +0 </response>
     </vote>
     <vote title="Nominate Paul Ferraro as committer" date="Aug 24 2004" dev="RLS">
-      <motion> I would like to nominate Paul Ferraro as a Tapestry committer. Paul has shown a very good understanding of Tapestry, and recently made a large contribution with friendly URLs. (Paul has indicated he is very interested) </motion>
+      <motion> I would like to nominate Paul Ferraro as a Tapestry committer. Paul has shown a very good understanding of Tapestry, and recently made a large contribution with friendly URLs. (Paul 
+        has indicated he is very interested) </motion>
       <response>RLS, EH, HK, GL, DS: +1</response>
       <response>HLS, MB, TS, NC: +0</response>
     </vote>
     <!-- Vote for 3.0.1 release is missing! -->
     <vote title="Tapestry 3.0 FINAL" date="Apr 14 2004" dev="HLS">
-      <motion> Despite a last minute flurry of bug fixes, the motion has passed and we'll be releasing the final Tapestry 3.0 release shortly. I'll be creating tagging and creating the final release shortly. Alas, it looks like Neil Clayton is no longer contributing to the Tapestry project. </motion>
+      <motion> Despite a last minute flurry of bug fixes, the motion has passed and we'll be releasing the final Tapestry 3.0 release shortly. I'll be creating tagging and creating the final release 
+        shortly. Alas, it looks like Neil Clayton is no longer contributing to the Tapestry project. </motion>
       <response>HLS, RLS, EH, HK, DS, TSV, MB: +1</response>
       <response>GL, NC: +0</response>
     </vote>
     <vote title="release 3.0-rc-3" date="Apr 7 2004" dev="HLS">
-      <motion> I've had some more time to knock down a the remaining blocker bugs in 3.0-rc-2. Assuming that there are no further blocker bugs added in the meantime, I'd like to release rc-3. A +1 vote indicates that we should release rc-3, unless a new blocker bug is added in the meantime. Please respond in the next 24 hours (by Wednesday afternoon, EST). Missing responses will be treated as a +0. </motion>
+      <motion> I've had some more time to knock down a the remaining blocker bugs in 3.0-rc-2. Assuming that there are no further blocker bugs added in the meantime, I'd like to release rc-3. A +1 
+        vote indicates that we should release rc-3, unless a new blocker bug is added in the meantime. Please respond in the next 24 hours (by Wednesday afternoon, EST). Missing responses will be 
+        treated as a +0. </motion>
       <response> HLS, EH, HK, DS: +1 </response>
       <response> NC, RLS, MB, TSV, GL: +0 </response>
     </vote>
@@ -549,11 +544,14 @@
       <response> RLS, GL, HK, EH, DS, MB, HLS: +1 </response>
     </vote>
     <vote title="Can the Tutorial" date="Feb 19 2004" dev="HLS">
-      <motion> I think its pretty obvious by now that no work is going to get done on the Tutorial for 3.0. I think it would be best to remove the Tutorial, perhaps replace it with a link to Kevin Dorff's site until we can actually put something useful together ... even if that is after 3.0 is released. A +1 vote would delete the Tutorial code, the docbook source and links to the old tutorial on the web site. </motion>
+      <motion> I think its pretty obvious by now that no work is going to get done on the Tutorial for 3.0. I think it would be best to remove the Tutorial, perhaps replace it with a link to Kevin 
+        Dorff's site until we can actually put something useful together ... even if that is after 3.0 is released. A +1 vote would delete the Tutorial code, the docbook source and links to the old 
+        tutorial on the web site. </motion>
       <response> HLS, EH, DS, GL, MB, HK: +1 </response>
     </vote>
     <vote date="Sep 5 2003" title="Release 3.0-beta-3" dev="HLS">
-      <motion> People have been itching for the next release of Tapestry; one where the demos work (woops!) including JavaScript and the Palette. Documentation is still not ready for an rc release, but I think a beta release is a good idea. </motion>
+      <motion> People have been itching for the next release of Tapestry; one where the demos work (woops!) including JavaScript and the Palette. Documentation is still not ready for an rc release, 
+        but I think a beta release is a good idea. </motion>
       <response> HLS, GL, RLS, DS, HK, EH, MB, TS, NC: +1 </response>
     </vote>
     <vote date="Sep 3 2003" title="Erik Hatcher as commiter" dev="GL">
@@ -562,17 +560,22 @@
       <response> NC: +0 (no vote) </response>
     </vote>
     <vote date="Sep 3 2003" title="Tsvetelin Saykov as committer" dev="MB">
-      <motion>I would like to nominate Tsvetelin Saykov as a committer. Tsvetelin has more than an year and a half of Tapestry experience, has worked with many large web projects, and can be very helpful overall for the development of the framework, especially in the area of dynamic pages with layout determined at runtime. (not to mention that he would need CVS access to work on the Tree) </motion>
+      <motion>I would like to nominate Tsvetelin Saykov as a committer. Tsvetelin has more than an year and a half of Tapestry experience, has worked with many large web projects, and can be very 
+        helpful overall for the development of the framework, especially in the area of dynamic pages with layout determined at runtime. (not to mention that he would need CVS access to work on the 
+        Tree) </motion>
       <response> MB, HLS, GL, DS, NC, RLS: +1 </response>
     </vote>
     <vote date="Sep 2 2003" title="Harish Krishnaswamy as committer" dev="HLS">
-      <motion> I would like to nominate Harish; he has been very actively and enthusiastically supporting Tapestry in the mailing lists. I think he would be an excellent and valuable asset to the team. And hell, he's relatively local --- I might actually get to meet a Tapestry committer in person! </motion>
+      <motion> I would like to nominate Harish; he has been very actively and enthusiastically supporting Tapestry in the mailing lists. I think he would be an excellent and valuable asset to the 
+        team. And hell, he's relatively local --- I might actually get to meet a Tapestry committer in person! </motion>
       <response> HLS, GL, DS, MB, RLS: +1 </response>
       <response> NC: +0 (no vote) </response>
     </vote>
     <vote date="Jul 13 2003" title="Release 3.0-beta-2" dev="HLS">
-      <motion> We informally discussed this not too long ago; I think we are at a good point for beta-2. There have been some significant improvements since beta-1a that will largely be invisible to most users (the correct thing for a beta release); at the same time, I think we're all anxious to push forward and get Tapestry 3.0-xxx into wider distribution. Although there are still several outstanding bugs (one or two that are problematic) I think this is a good time to keep momentum going and 
-        release the next beta. A +1 vote will procede with beta-2, tagging the repository and pushing the new releases out to the Apache distribution mirrors. </motion>
+      <motion> We informally discussed this not too long ago; I think we are at a good point for beta-2. There have been some significant improvements since beta-1a that will largely be invisible to 
+        most users (the correct thing for a beta release); at the same time, I think we're all anxious to push forward and get Tapestry 3.0-xxx into wider distribution. Although there are still 
+        several outstanding bugs (one or two that are problematic) I think this is a good time to keep momentum going and release the next beta. A +1 vote will procede with beta-2, tagging the 
+        repository and pushing the new releases out to the Apache distribution mirrors. </motion>
       <response> HLS, MB, NC, RLS, GL, DS: +1 </response>
     </vote>
     <vote date="Jun 3 2003" title="Release 3.0-beta-1a" dev="RLS">



---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Mime
View raw message