tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Dotte (JIRA)" <tapestry-...@jakarta.apache.org>
Subject [jira] Commented: (TAPESTRY-706) Button component should deprecate "label" parameter, and use informal "value" instead
Date Wed, 26 Oct 2005 20:41:56 GMT
    [ http://issues.apache.org/jira/browse/TAPESTRY-706?page=comments#action_12356010 ] 

Ben Dotte commented on TAPESTRY-706:
------------------------------------

The label parameter is already marked as deprecated in Button.jwc. But if "value" is supplied
as an informal parameter it doesn't get printed on the button. There are two reasons in Button.renderFormComponent():

writer.begin("button")  should be  writer.begin("input")
and
if (label != null) writer.print(label)  should be  if (label != null) writer.attribute("value",
label);

This is how the Submit component does it. Otherwise you can have problems, for example, applying
a css style to the button text.

> Button component should deprecate "label" parameter, and use informal "value" instead
> -------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-706
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-706
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>  Environment: 4.0-beta-11
>     Reporter: Vjeran Marcinko

>
> Button component should deprecate "label" parameter, and use informal "value" instead.
Same as Submit component.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Mime
View raw message