tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Kuhnert (JIRA)" <tapestry-...@jakarta.apache.org>
Subject [jira] Commented: (TAPESTRY-1218) URL to dojo.js is not escaped
Date Sun, 21 Jan 2007 18:11:30 GMT

    [ https://issues.apache.org/jira/browse/TAPESTRY-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466336

Jesse Kuhnert commented on TAPESTRY-1218:

Are you guys sure about this? AjaxShellDelegate is just calling IAsset.buildURL() , which
in turn calls AssetService.getLink() which uses all of the normal tapestry URL encoding resources
to properly encode url's. 

The end result that I see with friendly urls turned off is the first example that Kent shows,
which is correct. If it were actually rendered as &amp; the browser would correctly detect
this to be an escape symbol and ignore it instead of using it as a valid character to implement
the http protocol for query parameters. 

Am I missing something?

> URL to dojo.js is not escaped
> -----------------------------
>                 Key: TAPESTRY-1218
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1218
>             Project: Tapestry
>          Issue Type: Bug
>          Components: XHR/dhtml/Ajax
>    Affects Versions: 4.1.1
>         Environment: WinXP. FireFox 2.0.
>            Reporter: Kent Tong
>             Fix For: 4.1.2
> The AjaxShellDelegate generates code like:
>     <script type="text/javascript" src="/AJAXApp/app?service=asset&path=%2Fdojo%2Fdojo.js"></script>
> but the & is not escaped. It should be:
>     <script type="text/javascript" src="/AJAXApp/app?service=asset&amp;path=%2Fdojo%2Fdojo.js"></script>
> I think http://jakarta.apache.org/commons/codec/apidocs/org/apache/commons/codec/net/URLCodec.html
should be used in the render() method in AjaxShellDelegate.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

View raw message