tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Köberl (JIRA) <tapestry-...@jakarta.apache.org>
Subject [jira] Commented: (TAPESTRY-1206) Asynchronous Selection Boxes work with Firefox 2.0 but not with Internet Explorer 6/7
Date Fri, 19 Jan 2007 13:09:30 GMT

    [ https://issues.apache.org/jira/browse/TAPESTRY-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466039
] 

Christian Köberl commented on TAPESTRY-1206:
--------------------------------------------

@Dave: 
the regular expression replace should work anyway because it should not match anything when
no options are present. At least it works for me IE6/WinXP.
You have an IE6 running on Linux?!

But your comment made me think about the patch and I realized the there could also be <OPTGROUP>
elements in there. So, the replace should be:
node.outerHTML=node.outerHTML.replace(/<OPT(ION|GROUP).*OPT(ION|GROUP)>/, content);

Here's the new patch:

Index: src/js/tapestry/core.js
===================================================================
--- src/js/tapestry/core.js (revision 497116)
+++ src/js/tapestry/core.js (working copy)
@@ -196,12 +196,15 @@
     
      dojo.event.browser.clean(node); // prevent mem leaks in ie
     
+ var content=tapestry.html.getContentAsString(element);
      if (djConfig["isDebug"]) {
- var content=tapestry.html.getContentAsString(element);
      dojo.log.debug("Received element content for id <" + id + "> of:", content);
+ }
+ // fix for IE - setting innerHTML does not work for SELECTs
+ if (dojo.render.html.ie && node.outerHTML && node.nodeName == "SELECT")
{
+ node.outerHTML=node.outerHTML.replace(/<OPT(ION|GROUP).*OPT(ION|GROUP)>/, content);
+ } else {
      node.innerHTML=content;
- } else {
- node.innerHTML=tapestry.html.getContentAsString(element);
      }
     
      // copy style/class css attributes


> Asynchronous Selection Boxes work with Firefox 2.0 but not with Internet Explorer 6/7
> -------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1206
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1206
>             Project: Tapestry
>          Issue Type: Bug
>          Components: XHR/dhtml/Ajax
>    Affects Versions: 4.1.1
>         Environment: We are using the 4.1.1 snapshots of tapestry
>            Reporter: Stefan Esterer
>         Attachments: screenshot_ie6.jpg, selectAjaxUpdate.zip, SelectionTest.html, SelectionTest.java,
SelectionTest.page
>
>
> We have discovered that the use of dependency in selection boxes leads to problems, if
you use asynchron calls and internet explorer.
> example files are attached below

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message