tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davor Hrg (JIRA)" <...@tapestry.apache.org>
Subject [jira] Commented: (TAPESTRY-1559) application package initializer removed while merging svn
Date Tue, 12 Jun 2007 07:00:32 GMT

    [ https://issues.apache.org/jira/browse/TAPESTRY-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503759
] 

Davor Hrg commented on TAPESTRY-1559:
-------------------------------------

Ill try to be more precise in defining the problem:

I have a simple app that works with 5.0.4
it uses tapestry-hibernate and holds hibernate-entities in appPackage.entities
hibernate fails to recognize these entities in 5.0.5-SNAPSHOT

I traced the problem myself to the following
HibernateModule adds "null.entities" to HibernateSessionSource configuration
this is caused by: ApplicationGlobals returning null for rootPackage 

.....

this was previously done in InternalModeule.contributeApplicationInitializer
my fault of course not to recognize the code was obsolete,

eclipse did not find references to TAPESTRY_APP_PACKAGE_PARAM for me,
but after using simple grep, it is obvious that injecting this value is now done in a more
proper way than the old code,

I found this in ComponentClassResolver
            @Inject
            @Symbol(InternalConstants.TAPESTRY_APP_PACKAGE_PARAM)
            String appRootPackage,


I am aware I've wasted your time by assuming the solution for the issue without focusing enough
to
finding the real cause of it, sorry about that.

never the less I'll again assume I can solve this issue properly so here's a patch
1559.patch


> application package initializer removed while merging svn
> ---------------------------------------------------------
>
>                 Key: TAPESTRY-1559
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1559
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Core Components
>    Affects Versions: 5.0.5
>         Environment: any
>            Reporter: Davor Hrg
>            Assignee: Howard M. Lewis Ship
>
> revision: #536053 (Marge changes from the temporary branch)
> a chunk of code was removed from 
> org.apache.tapestry.internal.services.InternalModule#contributeApplicationInitializer
> this code was responsible for setting TAPESTRY_APP_PACKAGE_PARAM to ApplicationGlobals
> this will cause problems, I noticed because my entities weren't recognized ba tapestry-hibernate
> the problematic code is clearly visible in the diff, so I'll omit a patch...
> perhaps the revision shoould be checked for any other deleted code
> that might cause problems....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message