tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Zeigler (JIRA)" <...@tapestry.apache.org>
Subject [jira] Commented: (TAPESTRY-1745) Palette javascript errors in Internet Explorer
Date Wed, 03 Oct 2007 19:39:50 GMT

    [ https://issues.apache.org/jira/browse/TAPESTRY-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532215
] 

Robert Zeigler commented on TAPESTRY-1745:
------------------------------------------

After some tracking (caveat: only have access to IE 7 at the moment, so there could be further
issues on IE 6...), I found two places where IE is choking.
1) in palette.js; IE reports it as line 183 (last line in the file), but it's actually line
182. Looks like:

  ...
  reorderSelected : function(movers,  before) {
    movers.each(function(option) { this.selected.add(option, before); }.bind(this));
    
    this.updateHidden();  
    this.updateButtons();
  },  
};

The culprit is the last comma; IE is apparently unforgiving of trailing commas in map/array
definitions.
Once you do that, the palette loads correctly, and almost functions correctly, too.
But there's another issue at line 132:

          to.add(option, before);

An innocuous line.  But according to: 
  http://www.quirksmode.org/dom/w3c_html.html#selects

There's some disagreement about the "before" argument among the major browsers.
W3C says it should be an option object, and mozilla, safari, and opera agree. Mozilla requires
the extra argument; safari and opera allow it.
IE allows the 2nd argument, but expects it to be the /index/ before which to insert the option,
rather than an option argument. Hence, the line above generates a "Type mismatch" error in
IE.

I'll try to attach a patch later today.



> Palette javascript errors in Internet Explorer
> ----------------------------------------------
>
>                 Key: TAPESTRY-1745
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.5
>            Reporter: Joel Wiegman
>
> A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and
7.0).  Javascript errors abound.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message