tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Sommerville (JIRA)" <...@tapestry.apache.org>
Subject [jira] Updated: (TAPESTRY-2324) Wrong Submit 'selected' event fired when using a Form with a Zone parameter
Date Thu, 01 May 2008 07:20:55 GMT

     [ https://issues.apache.org/jira/browse/TAPESTRY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ben Sommerville updated TAPESTRY-2324:
--------------------------------------

    Attachment: TAPESTRY-2324.patch

Patch fixes issue by observing the click event of all submit buttons within a (zone) form
and saving the name of the button that is clicked.  The submit handler then passes that name
to the form.request call as an option.

This fix also required patching prototype to properly pass on the submit option to the form
serialize method.  A prototype bug has been logged as:
http://prototype.lighthouseapp.com/projects/8886-prototype/tickets/66-form-request-does-not-pass-options-to-form-serialize

> Wrong Submit 'selected' event fired when using a Form with a Zone parameter
> ---------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2324
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2324
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Core Components
>    Affects Versions: 5.0.12
>         Environment: Jetty 5.1.12; Tapestry 5.0.12-SNAPSHOT
>            Reporter: Peter Beshai
>         Attachments: TAPESTRY-2324.patch
>
>
> Given the following code:
> void onSelectedFromSave()
> {
> 	System.out.println("save");	
> }
> void onSelectedFromCancelChanges()
> {
> 	System.out.println("cancel");
> }
> The following template outputs 'save' when clicking on the save button and 'cancel' when
clicking on the cancel button
> <t:form t:id="finalizeChanges" zone="testZone">				
> 	<t:submit t:id="save"/>
> 	<t:submit t:id="cancelChanges"/>
> </t:form>
> The following template/code outputs 'save' when clicking on the save button and 'save'
when clicking on the cancel button
> <t:zone t:id="testZone">		
> 	<t:form t:id="finalizeChanges" zone="testZone">				
> 		<t:submit t:id="save"/>
> 		<t:submit t:id="cancelChanges"/>
> 	</t:form>		
> </t:zone>
> The following template/code outputs 'cancel' when clicking on the save button and 'cancel'
when clicking on the cancel button
> <t:zone t:id="testZone">		
> 	<t:form t:id="finalizeChanges" zone="testZone">				
> 		<t:submit t:id="cancelChanges"/>
> 		<t:submit t:id="save"/>
> 	</t:form>		
> </t:zone>
> 	

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message