tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Blower (JIRA)" <...@tapestry.apache.org>
Subject [jira] Commented: (TAPESTRY-1997) PersistentLocale is lower-casing locales
Date Thu, 19 Jun 2008 15:35:46 GMT

    [ https://issues.apache.org/jira/browse/TAPESTRY-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606419#action_12606419
] 

Andy Blower commented on TAPESTRY-1997:
---------------------------------------

Thanks.

Regarding dependencies, T5 already has dependencies on commons-codec, commons-io and commons-upload
otherwise I wouldn't have suggested it. Still, you can always follow their code and do the
same in T5 somewhere. I've tested the fix out using LocaleUtils and it appears to work well.
I'm just trying out the localisation features for the first time though so I may well have
missed something.

> PersistentLocale is lower-casing locales
> ----------------------------------------
>
>                 Key: TAPESTRY-1997
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1997
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.6
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>
> An issue affecting localization: PersistentLocale is converting locales from mixed case
to all lower case, which is useless for formatting.  For example, if page 1 sets the locale
like this:
> 	@Inject
> 	private PersistentLocale _persistentLocaleService;
> 	Locale locale = Locale.UK;
> 	_persistentLocaleService.set(locale);
> 	System.out.println("locale is " + locale + " - " + locale.getDisplayName());
>  
> then this is what prints:
> 	locale is en_GB - English (United Kingdom)
> But when I'm in page 2 I get the locale and find it has mutated...
> 	Locale locale = _persistentLocaleService.get();
> 	System.out.println("locale is " + locale + " - " + locale.getDisplayName());
> ...this is what prints:
> 	locale is en_gb - en_gb
> This mutated locale in page 2 is useless for formatting.  Code like the following produces
default-styling instead of the styling for en_GB:
> 	_myDateFormat = DateFormat.getDateInstance(DateFormat.LONG, locale);
> 	System.out.println(_myDateFormat.format(new Date()));
> It seems this has also adversely affected how supported-locales are declared (maybe in
previous releases only).  See http://thread.gmane.org/gmane.comp.java.tapestry.user/56526/focus=56527

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message