tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuel aldana <ald...@gmx.de>
Subject Patch review 2nd...
Date Sat, 02 May 2009 23:52:57 GMT
This time for file-asset: https://issues.apache.org/jira/browse/TAP5-423.

Please review.

Open things are:
-For the start I introduced interface FileAssetAliasManager which has 
exactly there same signature and semantics as ClasspathAliasManager. 
IMHO ClasspathAliasManagerImpl and FileAssetAliasManagerImpl should 
implement the same interface. What do you think?
-I used some error messages for the stack trace. Maybe they should be 
extracted to the ServicesStrings.properties (which I haven't done yet)? 
What is the convention of putting strings there. For all error messages 
which can occur?
-@since tag is marked with a todo and not filled yet.

thanks.

-- 
 manuel aldana
 aldana@gmx.de
 software-engineering blog: http://www.aldana-online.de


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message