tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] Commented: (TAP5-945) Lock contention in PerthreadManagerImpl
Date Tue, 08 Dec 2009 22:17:18 GMT

    [ https://issues.apache.org/jira/browse/TAP5-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787780#action_12787780
] 

Howard M. Lewis Ship commented on TAP5-945:
-------------------------------------------

The JDK bug was fixed in JDK6 (http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5025230)
but may still exist in JDK 1.5.

Best option would be to disable the synchronization unless JDK 1.5.  That would be nice ...
some free performance boost for using JDK 1.6.

ReentrantReadWriteLock would also work but there's a bit of overhead there.

> Lock contention in PerthreadManagerImpl
> ---------------------------------------
>
>                 Key: TAP5-945
>                 URL: https://issues.apache.org/jira/browse/TAP5-945
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Olle Hallin
>            Priority: Minor
>
> When load testing our new high-volume site before soft launch, we found that we have
severe lock contention in org.apache.tapestry5.ioc.internal.services.PerthreadManagerImpl.
> It synchronizes on "this" before invoking ThreadLocal.get() and ThreadLocal.remove(),
which I believe is unnecessary. 
> During our tests, approximately  35% of all Tomcat threads were waiting for this lock
in any of 10 thread dumps taken 15 seconds apart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message