tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Massimo Lusetti (JIRA)" <j...@apache.org>
Subject [jira] Commented: (TAP5-945) Lock contention in PerthreadManagerImpl
Date Tue, 08 Dec 2009 21:50:18 GMT

    [ https://issues.apache.org/jira/browse/TAP5-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787764#action_12787764
] 

Massimo Lusetti commented on TAP5-945:
--------------------------------------

I will definitely for the latter.

BTW Olle could you try to remove the sync blocks and see what happen?

> Lock contention in PerthreadManagerImpl
> ---------------------------------------
>
>                 Key: TAP5-945
>                 URL: https://issues.apache.org/jira/browse/TAP5-945
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Olle Hallin
>            Priority: Minor
>
> When load testing our new high-volume site before soft launch, we found that we have
severe lock contention in org.apache.tapestry5.ioc.internal.services.PerthreadManagerImpl.
> It synchronizes on "this" before invoking ThreadLocal.get() and ThreadLocal.remove(),
which I believe is unnecessary. 
> During our tests, approximately  35% of all Tomcat threads were waiting for this lock
in any of 10 thread dumps taken 15 seconds apart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message