tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1596) Tapestry should validate that component ids reference in event handler method names (or @OnEvent annotation) exist
Date Mon, 08 Aug 2011 01:27:27 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080713#comment-13080713
] 

Hudson commented on TAP5-1596:
------------------------------

Integrated in tapestry-trunk-freestyle #454 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/454/])
    TAP5-1596: Update some tests that were broken by the new component id validation
TAP5-1596: Allow the new component id check to be optional, to ease upgrading from 5.2
TAP5-1596: Enhance OnEventWorker to check that component ids for event handler methods match
against actual component ids
TAP5-1596: Correct some test pages that referenced a non-existent component id via an event
handler method
TAP5-1596: Remove event handler for non-existent ActionLink 'reset'
TAP5-1596: Add a page to demonstrate the fix

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154800
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/InplaceGridDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/LeanGridDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/GridDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/InplaceGridDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/GridRemoveReorderDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/GridTests.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/GridDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/GridRemoveReorderDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LeanGridDemo.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154799
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154797
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/ComponentParameterTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154796
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/GridDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app2/pages/TestPageForLocale_fr.tml

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154793
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/FormInjectorDemo.java

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154791
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/EventMethodUnmatchedComponentId.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/EventMethodUnmatchedComponentId.tml


> Tapestry should validate that component ids reference in event handler method names (or
@OnEvent annotation) exist
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1596
>                 URL: https://issues.apache.org/jira/browse/TAP5-1596
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>              Labels: feedback
>             Fix For: 5.3
>
>
> The scenario is a component, say "register", and a event handler method, say "onValidateFromRegistry".
 Since "registry" is not a known component id, this should be flagged as an error early, say,
during page construction, or perhaps on page load.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message