tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dragan Sahpaski (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1843) Allow all of the properties of the Messages services to be accessed
Date Fri, 10 Feb 2012 16:14:59 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205522#comment-13205522
] 

Dragan Sahpaski commented on TAP5-1843:
---------------------------------------

Hi Omar,
I saw the commit right away just didn't get the time to comment.

My comment would have been the same as Thiago's.

I don't think copy constructor is also the way to go.

Maybe Iterator or something like that that is immutable. Or maybe it's best if you look at
other existing public interfaces and see how Map's values (in the implementation class) are
exposed for reading there. It would be easier to get your patch accepted if it consistent
with the way things are previously done in Tapestry.

Cheers,
Dragan
                
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
>                 Key: TAP5-1843
>                 URL: https://issues.apache.org/jira/browse/TAP5-1843
>             Project: Tapestry 5
>          Issue Type: New Feature
>    Affects Versions: 5.3.2, 5.2.6
>            Reporter: Omar Carvajal
>            Priority: Minor
>         Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message