tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (TAP5-1950) ResourceStreamer sends SC_NOT_MODIFIED as an error, but it should be just status
Date Wed, 06 Jun 2012 17:20:23 GMT

     [ https://issues.apache.org/jira/browse/TAP5-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Howard M. Lewis Ship closed TAP5-1950.

       Resolution: Fixed
    Fix Version/s: 5.4
         Assignee: Howard M. Lewis Ship
> ResourceStreamer sends SC_NOT_MODIFIED as an error, but it should be just status
> --------------------------------------------------------------------------------
>                 Key: TAP5-1950
>                 URL: https://issues.apache.org/jira/browse/TAP5-1950
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3.4, 5.4
> From a client:
> quick side note: currently we use tapestry-spring-security integration for web security.
In case a response.sendError(..) is called during the request the spring security filter will
create a HttpSession storing the current security context for that error in the http session
(default spring configuration behaviour for creating a HttpSession in a error case). This
behaviour (currently we rely on that) caused a serious bottleneck for anonymous users as a
lot of unnecessary HttpSessions were created and it was bascially triggered through the current
ResourceStreamerImpl implementation and the call  response.sendError(HttpServletResponse.SC_NOT_MODIFIED,
> I contributed my own HttpSessionWorkaroundResourceStreamerImpl implementation were I
just replaced the call response.sendError(HttpServletResponse.SC_NOT_MODIFIED, "") with response.setStatus(HttpServletResponse.SC_NOT_MODIFIED)
and then we made another big performance jump. So my question: Wouldn't be response.setStatus(HttpServletResponse.SC_NOT_MODIFIED)
"more" correct as it isn't an error (3xx<->5xx http codes)?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message