tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1808) Change Form to (by default) immediately render markup when there are validation errors, to avoid creating the session
Date Mon, 02 Jul 2012 18:23:23 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405204#comment-13405204

Howard M. Lewis Ship commented on TAP5-1808:

Yes it does.  There's a trade-off here.  On the one hand, we are vastly simplifying things
on the server, and significantly minimizing persistent state, as well as helping defer the
creation of the HttpSession.  On the other hand, forms with errors will be re-rerendered directly
in the component event request, meaning that the URL will display a component-event URL; at
least until the errors are corrected and the form submitted; at which point it will redirect
to a normal, stable, page render URL.
> Change Form to (by default) immediately render markup when there are validation errors,
to avoid creating the session
> ---------------------------------------------------------------------------------------------------------------------
>                 Key: TAP5-1808
>                 URL: https://issues.apache.org/jira/browse/TAP5-1808
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: form, redirect-after-action
>             Fix For: 5.4
> Historically, Tapestry has needed to keep an instance of ValidationTracker in the session
between a form submit and a page re-render, to track user input and input errors; this often
means that it is necessary to create the HttpSession just to store this transient value. 
Tapestry 5.2 went through some contusions to avoid creating the persistent ValidationTracker
instance until there were actual errors, to avoid creating the session.
> A better approach is to treat successful and failed form submits differently, at least
by default. For failed form submits, where the default is to re-render the active page, the
Form component could instead immediately re-render the page.  The ValidationTracker instance
would not ever have to be persistent at that point.
> In this way, failed form submissions would be treated somewhat like requests with unhandled
exceptions: markup is streamed to the client web browser even during a component event request.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message