tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Markov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAP5-2031) BaseURLSourceImpl added default secure port to absolute url
Date Fri, 30 Nov 2012 08:55:57 GMT

     [ https://issues.apache.org/jira/browse/TAP5-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrei Markov updated TAP5-2031:
--------------------------------

    Description: 
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for secure url.

if (port <= 0) { 
    port = request.getServerPort();
    int schemeDefaultPort = request.isSecure() ? 443 : 80;
    portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;

The last line doesn't check secure flag, but it should be.
  

  was:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with secure scheme.

if (port <= 0) { 
    port = request.getServerPort();
    int schemeDefaultPort = request.isSecure() ? 443 : 80;
    portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;

The last line doesn't check secure flag, but it should be.
  

    
> BaseURLSourceImpl added default secure port to absolute url
> -----------------------------------------------------------
>
>                 Key: TAP5-2031
>                 URL: https://issues.apache.org/jira/browse/TAP5-2031
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.1
>            Reporter: Andrei Markov
>            Priority: Trivial
>
> BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for secure url.
> if (port <= 0) { 
>     port = request.getServerPort();
>     int schemeDefaultPort = request.isSecure() ? 443 : 80;
>     portSuffix = port == schemeDefaultPort ? "" : ":" + port;
> }
> else if (secure && port != 443) portSuffix = ":" + port;
> else if (port != 80) portSuffix = ":" + port;
> The last line doesn't check secure flag, but it should be.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message