tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bob Harner <bobhar...@gmail.com>
Subject Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404
Date Wed, 13 Feb 2013 15:16:53 GMT
A very minor issue: The "SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT" name
seems to miss the mark a bit.

For consistency with other symbol names, maybe
"UNKNOWN_ACTIVATION_CONTEXT_CHECK_ENABLED" ?

    http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/SymbolConstants.html

On Wed, Feb 13, 2013 at 9:55 AM, Massimo Lusetti <mlusetti@gmail.com> wrote:
> On Wed, Feb 13, 2013 at 3:36 PM, Ulrich Stärk <uli@spielviel.de> wrote:
>
> +1 on the idea, -1 on the implementation.
>>
>> In PageActivatorImpl you set send404 from the symbol but never check on it.
>>
>>
> Right.
> The patch is wrong, It's not PRODUCTION_MODE that has to be check
> is SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT... That's the honeypot for
> everyone commenting the issue ;-)
>
> --
> Massimo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message