tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Kemnade (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAP5-2217) JS modules from stack are not added when COMBINE_SCRIPTS is false
Date Tue, 05 Nov 2013 10:04:19 GMT

     [ https://issues.apache.org/jira/browse/TAP5-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jochen Kemnade updated TAP5-2217:
---------------------------------

    Description: 
When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem is
that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}}
only adds the stack's libraries if {{combineScripts}} is {{false}}.
The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal
of
{code:java}
        for (String moduleName : stack.getModules())
        {
            require(moduleName);
        }
{code]
in {{org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)}}.

  was:
When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem is
that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}}
only adds the stack's libraries if `combineScripts` is {{false}}.
The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal
of
{{
        for (String moduleName : stack.getModules())
        {
            require(moduleName);
        }
}}
in `org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)`.


> JS modules from stack are not added when COMBINE_SCRIPTS is false
> -----------------------------------------------------------------
>
>                 Key: TAP5-2217
>                 URL: https://issues.apache.org/jira/browse/TAP5-2217
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Priority: Blocker
>
> When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem
is that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}}
only adds the stack's libraries if {{combineScripts}} is {{false}}.
> The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal
of
> {code:java}
>         for (String moduleName : stack.getModules())
>         {
>             require(moduleName);
>         }
> {code]
> in {{org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)}}.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message