tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2217) JS modules from stack are not added when COMBINE_SCRIPTS is false
Date Mon, 11 Nov 2013 18:59:17 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819220#comment-13819220
] 

Howard M. Lewis Ship commented on TAP5-2217:
--------------------------------------------

My original intent was that I would close this without action; this is an incompatible change
from one alpha version to another.

However, on reflection, there's no reason why we can't support the old behavior (automatically
requireing the modules) when in development mode (that is, not combining scripts) and support
the new behavior (inserting the tweaked source into the virtual library asset) when combining
scripts.

> JS modules from stack are not added when COMBINE_SCRIPTS is false
> -----------------------------------------------------------------
>
>                 Key: TAP5-2217
>                 URL: https://issues.apache.org/jira/browse/TAP5-2217
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Howard M. Lewis Ship
>            Priority: Blocker
>
> When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem
is that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}}
only adds the stack's libraries if {{combineScripts}} is {{false}}.
> The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal
of
> {code:java}
>         for (String moduleName : stack.getModules())
>         {
>             require(moduleName);
>         }
> {code}
> in {{org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)}}.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message