tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Howard Lewis Ship <hls...@gmail.com>
Subject Re: git commit: Revert "update ANTLR to 3.5.2, fixes issues when building the grammar with Java 8" Less4j is not compatible with ANTLR 3.5
Date Fri, 18 Jul 2014 15:47:20 GMT
This is very surprising, as I ran the full test suite with this change in
place, and the Less4J related code in tapestry-webresources worked
properly. What are the symptoms?


On Fri, Jul 18, 2014 at 12:37 AM, <jkemnade@apache.org> wrote:

> Repository: tapestry-5
> Updated Branches:
>   refs/heads/master 2667b5a9d -> 4bd6302e0
>
>
> Revert "update ANTLR to 3.5.2, fixes issues when building the grammar with
> Java 8"
> Less4j is not compatible with ANTLR 3.5
>
> This reverts commit 7702038519af9a548de52b757446b02212f7165f.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4bd6302e
> Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4bd6302e
> Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4bd6302e
>
> Branch: refs/heads/master
> Commit: 4bd6302e0eca754b86e0cb2a9a0ab1ec6270857c
> Parents: 2667b5a
> Author: Jochen Kemnade <jochen.kemnade@eddyson.de>
> Authored: Fri Jul 18 09:36:22 2014 +0200
> Committer: Jochen Kemnade <jochen.kemnade@eddyson.de>
> Committed: Fri Jul 18 09:36:32 2014 +0200
>
> ----------------------------------------------------------------------
>  tapestry-core/build.gradle | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4bd6302e/tapestry-core/build.gradle
> ----------------------------------------------------------------------
> diff --git a/tapestry-core/build.gradle b/tapestry-core/build.gradle
> index c16cd48..41c2adf 100644
> --- a/tapestry-core/build.gradle
> +++ b/tapestry-core/build.gradle
> @@ -27,12 +27,12 @@ dependencies {
>      compile "commons-codec:commons-codec:1.5"
>
>      // Transitive will bring in the unwanted string template library as
> well
> -    compile "org.antlr:antlr-runtime:3.5.2", {
> +    compile "org.antlr:antlr-runtime:3.3", {
>          exclude group: "org.antlr", module: "stringtemplate"
>      }
>
>      // Antlr3 tool path used with the antlr3 task
> -    antlr3 "org.antlr:antlr:3.5.2"
> +    antlr3 "org.antlr:antlr:3.3"
>
>      testRuntime "org.hsqldb:hsqldb:1.8.0.10"
>  }
>
>


-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com
@hlship

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message