tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2139) It should be possible to control whether a given JavaScript library is minimized or not
Date Tue, 01 Jul 2014 15:54:24 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048985#comment-14048985
] 

Hudson commented on TAP5-2139:
------------------------------

SUCCESS: Integrated in tapestry-trunk-freestyle #1271 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1271/])
TAP5-2139: It should be possible to control whether a given JavaScript library is minimized
or not (hlship: rev accbb5374aa29333d2a666d4225c66a77b56581f)
* 54_RELEASE_NOTES.md
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/JavaScriptStackAssemblerImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StackExtension.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/JavaScriptStackAssembler.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavaScriptStackPathConstructorImpl.java
* tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java
* tapestry-core/src/main/java/org/apache/tapestry5/TapestryConstants.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/StackAssetRequestHandler.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavaScriptStackSourceImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/ExtensibleJavaScriptStack.java
* tapestry-core/src/main/java/org/apache/tapestry5/modules/AssetsModule.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStackSource.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/JavaScriptStackMinimizeDisabler.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StackExtensionType.java
* tapestry-webresources/src/test/java/t5/webresources/services/AppModule.java
* tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/AbstractMinimizer.java
* tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavascriptAggregationStrategy.java


> It should be possible to control whether a given JavaScript library is minimized or not
> ---------------------------------------------------------------------------------------
>
>                 Key: TAP5-2139
>                 URL: https://issues.apache.org/jira/browse/TAP5-2139
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-webresources
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.4
>
>
> The current closure compiler version fails to minimize angular.js (https://github.com/angular/angular.js/issues/1304).
A WroRuntimeException is thrown from GoogleClosureCompressorProcessor which is not handled,
so the asset is not sent to the client at all.
> When an asset cannot be minimized for whatever reason, Tapestry should just send the
original asset.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message